Adds dark mode and simplify CSS #42
Conversation
- remove class="box", the code already has a different background color - simplify the table style to be closer to ReSpec - add explicit <code> in the table - drop the style block that is unused
spec/index.html
Outdated
| @@ -382,83 +95,83 @@ <h2>Introduction</h2> | |||
| <section id="example1"> | |||
| <h3>Example</h3> | |||
| <p>The following artificial example is used to illustrate the features of serializing results in each format.</p> | |||
| <table class="result"> | |||
| <table> | |||
There was a problem hiding this comment.
The table borders are lost (light and dark modes) because of the lack of class="result" and it's CSS.
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
There was a problem hiding this comment.
Simple reverting the removal will not fix the issue.
The missing borders are due to removal of the CSS and its application via class.
If reSpec has a way to do it, the fix might be to adopt the reSpec way.
There was a problem hiding this comment.
I have added back borders.
Personally, if I would tend to think that following closely ReSpec stylesheet will make things easier in the future.
There was a problem hiding this comment.
Added to td not th?
c.f.
https://www.w3.org/TR/sparql12-results-csv-tsv/#example1
https://www.w3.org/TR/sparql11-results-csv-tsv/#example1
I don't care for the inter-cell gaps but just a black border on white everywhere is
We can try the reSpec way. This document can be a experiment.
There was a problem hiding this comment.
Added to td not th?
Indeed, my bad. Fixed. Thanks!
We can try the reSpec way. This document can be a experiment.
The reSpec default table rendering is the one it had when I first uploaded the PR: no border
There was a problem hiding this comment.
The reSpec default table rendering is the one it had when I first uploaded the PR: no border
Edit: There is actually a class="data" in the W3C stylesheet. There is no vertical borders but horizontal ones. Does it suits you? I have updated the PR to use it. https://www.w3.org/StyleSheets/TR/2021/README.html#table
|
The "Comment (not part of the table)" columns are quite confusing. They certainly appear to be part of the tables in which they appear... |
Indeed. However, I would love to avoid doing changes to the content in this MR and focus only on CSS |
Tpt
added
the
spec:editorial
codetags in the tablePreview | Diff