added ordering rationale: #158
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bogdandrutu
approved these changes
Aug 23, 2018
| @@ -31,6 +31,22 @@ interfere with identification of the tracing system responsible for an entry. | |||
| - The typical name will be a single word in latin and the value will be a | |||
| copy of the `traceparent` format or an opaque string. | |||
|
|
|||
| ## Ordering of keys in `tracestate` | |||
|
|
|||
| Specification calls for ordering of values in tracestate. This requirements allows better interoperability between tracing vendors. | |||
There was a problem hiding this comment.
I think this md file uses different line size based on whoever updates it. Probably makes sense to format the entire file using some rules. Maybe in a different PR. But at least in this PR use consistent line sizes please.
There was a problem hiding this comment.
I noticed this as well. I wonder if there is a setting common between vim and vscode that will control it. I'll configure this for vscode.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I suggest to close #123 with the words about ordering in rationale document. #123 refers to other two issues which are tracked separately already