Updated vocabulary and diagram #189
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iherman
requested review from
msporny,
Wind4Greg and
seabass-labrax
as code owners
Closed
Wind4Greg
approved these changes
Sep 8, 2023
TallTed
suggested changes
Sep 8, 2023
| <p> | ||
| The left side of the Proof Section contains another ellipse, | ||
| styled as Class and labeled as "ProofGraph", and connected | ||
| to the ellipse labeled as "Proof" with a connecting line styled as Contains. |
There was a problem hiding this comment.
styled as Contains makes me think the key should be changed from Graph Containment, which change I was going to suggest anyway.
There was a problem hiding this comment.
@TallTed I agree, but I would prefer to move that into a separate issue. The reason is that, for consistency's sake, this change should also be done in the VCDM, both in the descriptions and on the diagrams, and I do not want to mess up this PR for that. Would you agree? If so, can you put that into a separate issue? Thx.
Co-authored-by: Ted Thibodeau Jr <[email protected]>
msporny
approved these changes
Sep 18, 2023
|
Editorial, multiple reviews, changes requested and made, no objections, merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that the DI spec itself is ready for CR, this PR syncs up the vocabulary, including the diagram, with the spec. The changes are:
digestMultibaseterm, with the caveat in the spec (whereby the term is at risk, and may change fordigestSRI) copied into the vocabulary as well. Note that this is the only hard, content change in the vocabulary.As usual, there is a preview of the results