Skip to content

Clarifying credential from verifiable credential #1009

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
David-Chadwick opened this issue Jan 14, 2023 · 16 comments
Closed

Clarifying credential from verifiable credential #1009

David-Chadwick opened this issue Jan 14, 2023 · 16 comments
Assignees
Labels
before CR editorial Purely editorial changes to the specification. pr exists terminology

Comments

@David-Chadwick
Copy link
Contributor

David-Chadwick commented Jan 14, 2023

The credential exists regardless of whether it has a cryptographic verification mechanism attached to it or not. Various (incompatible) verification methods exist which are being separately standardised. Nevertheless the underlying credential should be identical in all cases. Consequently many of the properties in the VCDM actually refer to the credential and not to the verifiable credential. Examples include: valid from, valid to, id, type, @context, issuer.
A PR is needed to ensure that all the properties that describe the credential refer to the credential and not to the verifiableCredential.
By way of example, the current (v1.1) text for identifier states
"The first identifier is for the verifiable credential and uses an HTTP-based URL. The second identifier is for the subject of the verifiable credential (the thing the [claims] are about)"
This should be more correctly stated as
"The first identifier is for the credential and uses an HTTP-based URL. The second identifier is for the subject of the credential (the thing the [claims] are about)"

Note that different proofing mechanisms may add their own id for the proof (i.e. for the verifiableCredential), akin to the serialNumber in X.509 public key certificates, and this should not be confused with the id of the credential.

@awoie
Copy link
Contributor

awoie commented Jan 17, 2023

I do agree with @David-Chadwick . I remember that the VCWG made this distinction between credentials and verifiable credentials in the past. A PR to fix these references make sense from my perspective.

@Sakurann
Copy link
Contributor

no objection with the direction to clarify.

just a nuance..

Nevertheless the underlying credential should be identical in all cases.

As defined in v1.1, the actual body of what is signed is different between JWS and LDP - hence transformation section of mapping to JWT claims in section 6.3.1.
I would agree that the data model used by a credential should be identical in all cases", though I honestly want a term "data model" to be defined explicitly. right now it is implicit, which I think have contributed to this confusion around data-model -> credential -> verifiable credential transformation.. not sure how much this will impact replacing verifiable credentialwithcredential` - concrete text would be helpful

@David-Chadwick
Copy link
Contributor Author

@Sakurann Since we are now making changes to v2, and not v1.1, then I believe/hope that the credential proofed by either a JWT or JSON-LD will be identical in all cases. i.e. we will adopt the "as well as" algorithm for JWT instead of "instead of".

I will produce some concrete text for you.

@decentralgabe
Copy link
Contributor

This should also add a media type for credential (unsecured)

@TallTed

This comment was marked as resolved.

@David-Chadwick
Copy link
Contributor Author

Thankyou. I used the wrong "'" :-)

@David-Chadwick
Copy link
Contributor Author

I dont know how the closure came about. I did not intend to close this issue. (It must have been some strange combination of characters that I pressed by mistake). Sorry!

@brentzundel brentzundel added editorial Purely editorial changes to the specification. ready for PR This issue is ready for a Pull Request to be created to resolve it labels Apr 4, 2023
@Sakurann Sakurann self-assigned this Apr 4, 2023
@iherman
Copy link
Member

iherman commented Apr 4, 2023

The issue was discussed in a meeting on 2023-04-04

  • no resolutions were taken
View the transcript

1.9. Clarifying credential from verifiable credential (issue vc-data-model#1009)

See github issue vc-data-model#1009.

Manu Sporny: I'll take this one. We need to do a pass through the specification..
… Now an editor needs to make sure we mean "credential" or "verifiable credential" appropriately. This is ready for PR. My expectation is we will largely refer to "verifiable credential" in the specification, since that's what the media type is about..

Kristina Yasuda: Can I help you with that?.

Manu Sporny: Absolutely..
… DavidC I'll add you too.

David Chadwick: Thanks.

@TallTed
Copy link
Member

TallTed commented Apr 5, 2023

@Sakurann — Would you please edit the markdown in #1009 (comment)? I suspect that either —

that `the data

— should be —

that "the data

— or —

all cases", though

— should be —

all cases`, though

— and I think that making either change will make the whole comment readable as intended.

@iherman
Copy link
Member

iherman commented Jun 8, 2023

The issue was discussed in a meeting on 2023-06-07

  • no resolutions were taken
View the transcript

2.6. Clarifying credential from verifiable credential (issue vc-data-model#1009)

See github issue vc-data-model#1009.

Brent Zundel: moving to issue 1009, assigned to Manu, DavidC and Kristina.
… wonder if this has been overtaken by events. How should we mark before or post CR?

Orie Steele: Suggest closing this, the group has essentially resolved there is no difference.

Orie Steele: There is not spec legal way to distinguish between credential and verifiable credential.

David Chadwick: this needs someone to carefully go through current version and ensure use of credential or verifiable credential are proper and submit editorial change.

Orie Steele: indeed, the base media type explains that you never know.

Joe Andrieu: Appreciate the clarification. Agrees the language in the spec is confusing.

Orie Steele: +1 to what Joe said. Base media type does not talk about securing mechanism.

Brent Zundel: suggests to make this as post CR.

Orie Steele: this may effect normative statements. esp the definition of what a proof is. Must be addressed before CR.

Brent Zundel: adding before CR label.

@OR13
Copy link
Contributor

OR13 commented Jun 30, 2023

@brentzundel @Sakurann this seems pretty critical to start fixing

@brentzundel
Copy link
Member

I believe this Issue may be superseded by #1126
I am marking it as pending close and will do so in 7 days if no one objects.

@brentzundel brentzundel added the pending close Close if no objection within 7 days label Jul 13, 2023
@David-Chadwick
Copy link
Contributor Author

I object simply because #1126 is necessary but not sufficient to address this issue. Lets see how #1126 pans out with a PR before closing this issue, since it is important that this issue is fully resolved in the v2 DM

@brentzundel brentzundel removed the pending close Close if no objection within 7 days label Jul 20, 2023
@OR13
Copy link
Contributor

OR13 commented Jul 20, 2023

Seems we are nearly needing a label for "blocked-by-credential-vs-verifiable-credential"

@msporny
Copy link
Member

msporny commented Jul 23, 2023

I have raised #1211 in an attempt to address this issue. If #1211 is merged, this issue will be closed.

@msporny msporny added pr exists and removed ready for PR This issue is ready for a Pull Request to be created to resolve it labels Jul 23, 2023
@msporny
Copy link
Member

msporny commented Aug 20, 2023

PR #1211 has been merged, closing.

@msporny msporny closed this as completed Aug 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
before CR editorial Purely editorial changes to the specification. pr exists terminology
Projects
None yet
Development

No branches or pull requests

9 participants