-
Notifications
You must be signed in to change notification settings - Fork 115
Clarifying credential from verifiable credential #1009
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
I do agree with @David-Chadwick . I remember that the VCWG made this distinction between credentials and verifiable credentials in the past. A PR to fix these references make sense from my perspective. |
no objection with the direction to clarify. just a nuance..
As defined in v1.1, the actual body of what is signed is different between JWS and LDP - hence transformation section of mapping to JWT claims in section 6.3.1. |
@Sakurann Since we are now making changes to v2, and not v1.1, then I believe/hope that the credential proofed by either a JWT or JSON-LD will be identical in all cases. i.e. we will adopt the "as well as" algorithm for JWT instead of "instead of". I will produce some concrete text for you. |
This should also add a media type for credential (unsecured) |
This comment was marked as resolved.
This comment was marked as resolved.
Thankyou. I used the wrong "'" :-) |
I dont know how the closure came about. I did not intend to close this issue. (It must have been some strange combination of characters that I pressed by mistake). Sorry! |
The issue was discussed in a meeting on 2023-04-04
View the transcript1.9. Clarifying credential from verifiable credential (issue vc-data-model#1009)See github issue vc-data-model#1009. Manu Sporny: I'll take this one. We need to do a pass through the specification.. Kristina Yasuda: Can I help you with that?. Manu Sporny: Absolutely.. David Chadwick: Thanks. |
@Sakurann — Would you please edit the markdown in #1009 (comment)? I suspect that either —
— should be —
— or —
— should be —
— and I think that making either change will make the whole comment readable as intended. |
The issue was discussed in a meeting on 2023-06-07
View the transcript2.6. Clarifying credential from verifiable credential (issue vc-data-model#1009)See github issue vc-data-model#1009. Brent Zundel: moving to issue 1009, assigned to Manu, DavidC and Kristina.
David Chadwick: this needs someone to carefully go through current version and ensure use of credential or verifiable credential are proper and submit editorial change.
Joe Andrieu: Appreciate the clarification. Agrees the language in the spec is confusing. Orie Steele: +1 to what Joe said. Base media type does not talk about securing mechanism. Brent Zundel: suggests to make this as post CR. Orie Steele: this may effect normative statements. esp the definition of what a proof is. Must be addressed before CR. Brent Zundel: adding before CR label. |
@brentzundel @Sakurann this seems pretty critical to start fixing |
I believe this Issue may be superseded by #1126 |
Seems we are nearly needing a label for "blocked-by-credential-vs-verifiable-credential" |
PR #1211 has been merged, closing. |
Uh oh!
There was an error while loading. Please reload this page.
The credential exists regardless of whether it has a cryptographic verification mechanism attached to it or not. Various (incompatible) verification methods exist which are being separately standardised. Nevertheless the underlying credential should be identical in all cases. Consequently many of the properties in the VCDM actually refer to the credential and not to the verifiable credential. Examples include: valid from, valid to, id, type,
@context
, issuer.A PR is needed to ensure that all the properties that describe the credential refer to the credential and not to the verifiableCredential.
By way of example, the current (v1.1) text for identifier states
"The first identifier is for the
verifiable credential
and uses an HTTP-based URL. The second identifier is for thesubject
of theverifiable credential
(the thing the [claims] are about)"This should be more correctly stated as
"The first identifier is for the
credential
and uses an HTTP-based URL. The second identifier is for thesubject
of thecredential
(the thing the [claims] are about)"Note that different proofing mechanisms may add their own
id
for the proof (i.e. for the verifiableCredential), akin to the serialNumber in X.509 public key certificates, and this should not be confused with theid
of thecredential
.The text was updated successfully, but these errors were encountered: