-
Notifications
You must be signed in to change notification settings - Fork 120
Description
handles in brackets indicate the author of that paragraph
Originally posted by @TallTed and @iherman in w3c/vc-data-integrity#175 (comment)
[@TallTed] I noticed the OR circle. I think that's trying to say that "
VerifiablePresentation
ORVerifiableCredential
could be Domain (a/k/aschema:domainIncludes VerifiablePresentation, VerifiableCredential
; cannot berdfs:domain
because the two classes are disjoint) oftermsOfUse
,validFrom
,validUntil
" — but I don't understand why this would only apply to those three properties. To my mind (and I hope the text and all bear this out), most if not all pictured properties should haveschema:domainIncludes VerifiablePresentation, VerifiableCredential
. In any case, I would make all these arrows complete arcs, and do away with the OR as well as the vertical connectors now seen betweenVerifiablePresentation
,OR
, andVerifiableCredential
.
[@TallTed] Note: The current version of the diagram does not have "the OR circle" which was at the point where the vertical line between VerifiablePresentation
and VerifiableCredential
meet the three arcs to termsOfUse
, validFrom
, and validUntil
.
- [@iherman] For the OR node: the diagram reflects what is in the vocabulary which, on its turn, reflects the spec at least the way I understand it. The 'issuer', 'evidence', etc, properties are only mentioned in conjunction with a credential and not with a presentation. I am not the domain expert here, any change should come from the VCDM spec.
[@TallTed] Ayie! It's doubly good we have these diagrams now, and that they were generated based-on/from the vocabs, which were generated based-on/from the spec — because this shows that the specs and the vocabs are wrong!
[@TallTed] The wrongness I see is that only 3 of the pictured properties have schema:domainIncludes
both of the classes (VerifiablePresentation
and VerifiableCredential
); i.e., that only VerifiablePresentation
may have a holder
(VerifiableCredential
may not), while only VerifiableCredential
may have a credentialSchema or confidenceMethod (among others, which VerifiablePresentation
may not).
[@iherman] Whether it is wrong or not, I do not know. I am in the humble position of translating the spec into the RDF world, and I do not claim to be a domain expert for VCs and VPs.
[@iherman] @TallTed I would prefer not to discuss this problem in this issue. Would you mind raising a separate issue in the VCDM repo and possibly discuss it there?
[@TallTed] The current version of the diagram in question (which is evolving, so may not now exactly match the description written here) is: