Skip to content

JSON-LD Reference #537

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
nadalin opened this issue Apr 8, 2019 · 12 comments
Closed

JSON-LD Reference #537

nadalin opened this issue Apr 8, 2019 · 12 comments
Labels
pending close Close if no objection within 7 days
Milestone

Comments

@nadalin
Copy link

nadalin commented Apr 8, 2019

Should this specification actually be built on JSON-LD 1.1 to better align with JSON structures which would align better with JWT

@chaals
Copy link
Contributor

chaals commented Apr 8, 2019

Updated. The original comment was based on misunderstanding the issue, and should be ignored because it doesn't relate to the issue

This seems like a rehash of #491, and other related issues. The answer to the question has been provided repeatedly:

- #491 (comment)
- #491 (comment)
- #483 (comment)
- #483 (comment)

as well as discussed at the last face to face meeting and various other places.

I believe this issue brings nothing new and should be closed without action.

@nadalin
Copy link
Author

nadalin commented Apr 8, 2019

@chaals not a rehash at all as specification lists JSON-LD 1.0 and my comments is that some issues may be resolved if this specification is based upon JSON-LD 1.1

@chaals
Copy link
Contributor

chaals commented Apr 9, 2019

Ah, sorry, that wasn't clear to me. Suggest changing the issue title to something like "refer to JSON-LD 1.1 instead of 1.0?" ...

At which point I support the proposal. Things like the internationalisation stuff pretty much rely on JSON-LD 1.1

@msporny
Copy link
Member

msporny commented Apr 10, 2019

JSON-LD 1.1 isn't a REC yet, only 1.0 is. That said, in reality, most of the implementations that we know are already using the JSON-LD 1.1 features that have shipped in processors for the @protected feature, which would address some of @nadalin's JSON-LD processing concerns.

In a previous WG, we published a REC that noted that it would upgrade to the latest version of a dependent spec when it hit REC. The WG closed, but the W3C staff updated the REC after it had been published and the dependent spec became a REC. So, there is precedent to do this even though the process is a bit shaky.

In any case, the group is already using JSON-LD 1.1 in practice... it would be good if we could align the spec w/ this reality rather than be limited by W3C Process.

@nadalin
Copy link
Author

nadalin commented Apr 10, 2019

@msporny We did this with WebAuthn and the CredMan support as it's not REC yet and we went to the WebAppSec folks and gota statement from them

@msporny
Copy link
Member

msporny commented Apr 10, 2019

@msporny We did this with WebAuthn and the CredMan support as it's not REC yet and we went to the WebAppSec folks and gota statement from them

Ok, then happy to do that wrt. the VC spec. I expect the JSON-LD 1.1 WG will support this, we will bring it up wrt. processing this issue during one of the next calls.

To front run a bit... hey, @iherman @BigBlueHat @azaroth42 -- could we schedule a call (in the next two months) with the JSON-LD 1.1 WG to get a statement from the WG that you intend to take the following features through to REC: @protected, scoped @contexts, and `"@container": "@graph"? We would like to cite the JSON-LD 1.1 spec as the normative spec for Verifiable Credentials instead of the JSON-LD 1.0 spec (with extensions, which is what we do today).

@chaals
Copy link
Contributor

chaals commented Apr 10, 2019

Yeah, there are other precedents for relying on spec stuff that isn't a REC yet - it's more a question of explaining why the reference is reliable enough and important enough to use, rather than being bound by a formal set of rules.

@burnburn burnburn added this to the CR-Exit milestone Apr 11, 2019
@brentzundel brentzundel added the ready for PR This issue is ready for a Pull Request to be created to resolve it label May 7, 2019
@burnburn
Copy link
Contributor

burnburn commented May 7, 2019

From VCWG call on 7 May 2019:
Issue #537 should be addressed by referencing JSON-LD 1.1 instead of JSON-LD 1.0. This is a non-substantive change since the Verifiable Credentials Data Model specification included JSON-LD 1.1 features inline for JSON-LD based processors and thus implementers would not have to change their implementations as a result of the updated reference. Issue #537 should be closed after the PR is merged.

@burnburn burnburn added the pending close Close if no objection within 7 days label May 7, 2019
@nadalin
Copy link
Author

nadalin commented May 7, 2019

@burnburn No closure until PR is created to see if this address issue

@burnburn
Copy link
Contributor

Yep. The 7 Day Close clock doesn't start until the PR is available.

@msporny
Copy link
Member

msporny commented Jul 3, 2019

PR #677 has been merged, which updates the reference from JSON-LD 1.0 to JSON-LD 1.1 per the WG resolution above. This issue will be closed on July 9th if there is no objection from the issue submitter.

@msporny msporny removed the ready for PR This issue is ready for a Pull Request to be created to resolve it label Jul 3, 2019
@burnburn
Copy link
Contributor

No objections raised during the 7 day close time. Closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pending close Close if no objection within 7 days
Projects
None yet
Development

No branches or pull requests

5 participants