Skip to content

Add issue to zkp section #1026

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 12, 2023
Merged

Add issue to zkp section #1026

merged 2 commits into from
Feb 12, 2023

Conversation

OR13
Copy link
Contributor

@OR13 OR13 commented Feb 2, 2023

@OR13 OR13 requested a review from msporny as a code owner February 2, 2023 22:00
@OR13 OR13 mentioned this pull request Feb 2, 2023
@Sakurann
Copy link
Contributor

Sakurann commented Feb 3, 2023

I thought we agreed to replace the section with a concrete shorter text that I think @brentzundel is working on.

@OR13
Copy link
Contributor Author

OR13 commented Feb 3, 2023

@Sakurann

You are corrrect, but....

I have yet to see a PR, and I think this issue can be merged before or after @brentzundel updates the section.

I still feel strongly that it is misleading to claim that W3C Verifiable Credentials support ZKPs when nothing standards track exists, and there are no normative requirements associated with ZKPs.

@brentzundel
Copy link
Member

brentzundel commented Feb 3, 2023

I am working on a PR, but agree that this PR can be merged at any time independent of the one I'm working on.

there are no normative requirements associated with ZKPs.

The v1.1 spec has normative requirements for using VCs with ZKPs, which is why we can't just delete the section (please note, I am not saying they are 'good' or 'testable' normative requirements). I am planning to address them as part of my PR.

Co-authored-by: Brent Zundel <[email protected]>
@brentzundel brentzundel mentioned this pull request Feb 8, 2023
@iherman
Copy link
Member

iherman commented Feb 9, 2023

The issue was discussed in a meeting on 2023-02-08

  • no resolutions were taken
View the transcript

3.1. Add issue to zkp section (pr vc-data-model#1026)

See github pull request vc-data-model#1026.

Manu Sporny: might remove zkp section.
… also have new P.R that changes the zkp section.
… need to decide how we are going to proces these.
… thoughts?.

Brent Zundel: #1030 incorporates and slightly changes the wording of #1026.

@msporny
Copy link
Member

msporny commented Feb 12, 2023

Editorial, multiple reviews, changes requested and made, no objections, decision to merge this before PR #1030 was approved on the last call, merging.

@msporny msporny merged commit 91661ee into main Feb 12, 2023
@msporny msporny deleted the fix/863-zkp-section branch February 12, 2023 20:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants