Skip to content

Remove "holder" from "VerifiableCredential" #1076

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 10, 2023
Merged

Remove "holder" from "VerifiableCredential" #1076

merged 1 commit into from
Apr 10, 2023

Conversation

OR13
Copy link
Contributor

@OR13 OR13 commented Apr 4, 2023

Sorta related - #959

@OR13
Copy link
Contributor Author

OR13 commented Apr 4, 2023

We also need to remove https://www.w3.org/2018/credentials/#holder from here perhaps, only the "VerifiableCredential" part...

Union of: cred:VerifiableCredential cred:VerifiablePresentation

to:

Union of: cred:VerifiablePresentation

@iherman iherman mentioned this pull request Apr 4, 2023
Closed
iherman added a commit that referenced this pull request Apr 5, 2023
@iherman
Change the domain statement of "holder"
c47199c 
Remove the VerifiableCredential from the possible domains of holder. This is the "execution" of #1076 (comment).

Beware! This is a PR against the OR13-remove-holder-from-vc PR, not against the main branch!
@iherman iherman mentioned this pull request Apr 5, 2023
Merged
@iherman
Copy link
Member

iherman commented Apr 5, 2023

We also need to remove https://www.w3.org/2018/credentials/#holder from here perhaps, only the "VerifiableCredential" part...

Union of: cred:VerifiableCredential cred:VerifiablePresentation

to:

Union of: cred:VerifiablePresentation

See #1078. We should not forget to merge that one before this if there is a consensus to merge.

@awoie
Copy link
Contributor

awoie commented Apr 5, 2023

IMO, we should remove all normative language on holder from the vocab too unless there is normative statements on holder in the VCDM spec itself.

awoie
awoie approved these changes Apr 5, 2023
View reviewed changes
Copy link
Contributor

@awoie awoie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@TallTed
Copy link
Member

TallTed commented Apr 5, 2023

@iherman — Why not make #1078 a suggested/requested change on #1076?

@msporny
Copy link
Member

msporny commented Apr 10, 2023

Substantive, multiple reviews, changes requested and made (to other PRs), no objections, merging.

@msporny msporny merged commit 8e5c82b into main Apr 10, 2023
@msporny msporny deleted the OR13-remove-holder-from-vc branch April 10, 2023 22:03
msporny pushed a commit that referenced this pull request Apr 10, 2023
@iherman @msporny
Change the domain statement of "holder"
42ceab2 
Remove the VerifiableCredential from the possible domains of holder. This is the "execution" of #1076 (comment).

Beware! This is a PR against the OR13-remove-holder-from-vc PR, not against the main branch!
msporny pushed a commit that referenced this pull request Apr 20, 2023
@iherman @msporny
Change the domain statement of "holder"
48ba14f 
Remove the VerifiableCredential from the possible domains of holder. This is the "execution" of #1076 (comment).

Beware! This is a PR against the OR13-remove-holder-from-vc PR, not against the main branch!
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@msporny msporny msporny approved these changes

@dlongley dlongley dlongley approved these changes

@vongohren vongohren vongohren approved these changes

@decentralgabe decentralgabe decentralgabe approved these changes

@awoie awoie awoie approved these changes

@selfissued selfissued Awaiting requested review from selfissued selfissued is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@OR13 @iherman @awoie @TallTed @msporny @dlongley @vongohren @decentralgabe