-
Notifications
You must be signed in to change notification settings - Fork 116
Add relatedResource
and digestSRI
to the vocabulary
#1296
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
msporny
merged 9 commits into
main
from
iherman-add-related-resource-and-digestSRI-to-vocab
Oct 16, 2023
Merged
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
3400387
Changes/additions
iherman 1b404c6
Merge branch 'main' into iherman-add-related-resource-and-digestSRI-t…
iherman 6c33467
- Updated the diagram, finalized the vocabulary (there were syntax er…
iherman d404b07
Updating the value space definition
iherman 0632992
Apply suggestions from code review
iherman d43e1dc
Apply suggestions from code review
iherman 16eaf39
Changing the top URL
iherman 512faeb
Change the URL-s in the diagram to be full W3C URL
iherman b4031ef
Handled the mess around relateive URLs
iherman File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -8,8 +8,9 @@ | |
.vscode | ||
.idea | ||
.gitignore | ||
*.bkp | ||
|
||
**/node_modules | ||
**/.DS_Store | ||
**/.vscode | ||
**/package-lock.json | ||
**/package-lock.json |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm, do we want both of these as top-level values... or do we want them under
relatedResource
. I would imagine we'd want the latter? /cc @dlongley @davidlehnThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@msporny I am open either way, I leave the decision to you guys.
My argument for this setup is that
digestSRI
might be useful elsewhere; there is nothing in the definition that is really bound torelatedResource
. After all, this is a general mechanism. (Note that the domain ofdigestSRI
is essentially open-ended, see also #1296 (comment)). But, again, I regard this as a VCDM domain issue, and I am not a VCDM expert, so to say...