Add PR review process for 2021 #774
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brentzundel
approved these changes
Apr 27, 2021
TallTed
reviewed
Apr 27, 2021
1 task
kdenhartog
approved these changes
Apr 28, 2021
davidlehn
reviewed
Apr 28, 2021
Co-authored-by: David I. Lehn <[email protected]>
msporny
reviewed
Apr 28, 2021
|
This is ready to merge based on the call today. |
|
The issue was discussed in a meeting on 2021-06-14
View the transcript4.1. Add PR review process for 2021 (pr vc-data-model#774)See github pull request #774. Manu Sporny: Wayne's PR, some suggestion were made in the comment, they have not been processed David Chadwick: clarify - what is version 1.2 (in PRs) Brent Zundel: quick editorial changes are set for version 1.1 and can go out a.s.a.p. - substantial changes, bugs, etc. are in version 1.2
Brent Zundel: any question? Manu Sporny: will merge pr 774 once the update has been made, comment added |
Co-authored-by: Manu Sporny <[email protected]>
|
multiple positive reviews, feedback received and incorporated, merging |
kdenhartog
added a commit
that referenced
this pull request
Jul 31, 2021
* Add PR review process for 2021. * Avoid GitHub id auto-linking. Co-authored-by: David I. Lehn <[email protected]> * Update README.md Co-authored-by: Manu Sporny <[email protected]> Co-authored-by: Manu Sporny <[email protected]> Co-authored-by: David I. Lehn <[email protected]> Co-authored-by: Brent Zundel <[email protected]> Co-authored-by: wyc <[email protected]> Co-authored-by: Manu Sporny <[email protected]> Co-authored-by: David I. Lehn <[email protected]> Co-authored-by: Brent Zundel <[email protected]>
kdenhartog
pushed a commit
that referenced
this pull request
Aug 24, 2021
* Add PR review process for 2021 (#774) * Add PR review process for 2021. * Avoid GitHub id auto-linking. Co-authored-by: David I. Lehn <[email protected]> * Update README.md Co-authored-by: Manu Sporny <[email protected]> Co-authored-by: Manu Sporny <[email protected]> Co-authored-by: David I. Lehn <[email protected]> Co-authored-by: Brent Zundel <[email protected]> * Update index.html tries to partially (diagram changes are also needed) fix #777, by uncoloring and adjusting the text * Apply suggestions from code review Cleaned up markdown tags, and added word missed previously Co-authored-by: wyc <[email protected]> Co-authored-by: Manu Sporny <[email protected]> Co-authored-by: David I. Lehn <[email protected]> Co-authored-by: Brent Zundel <[email protected]>
kdenhartog
added a commit
that referenced
this pull request
Sep 30, 2021
This reverts commit 1f574ef.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This process resulted from a series of meetings involving Brent Zundel, Wayne Chang, Manu Sporny, and Ivan Herman. Additional reviewers very welcome!