Update ZKP tests for changes in VC Data Model v1.1 #127
Conversation
- Remove requirement for credentialSchema - Remove requirement for verifiable presentation proof - Add skipped test for credential definition - Add skipped test about derived verifiable credential
|
The issue was discussed in a meeting on 2022-02-09
View the transcript4.1. [Tracking Issue - Proposed Corrections Feedback] Test suite improvements are needed (issue vc-test-suite#126)See github issue vc-test-suite#126. Charles Lehner: Tallted has commented on this.
See github pull request vc-test-suite#123. Charles Lehner: when a test has not been evaluated or when feature did not previously exist, I still need to respond to TallTed. See github pull request vc-test-suite#127. Brent Zundel: is there anyone on the call that can review these?. Manu Sporny: you can add me. |
| it.skip('credential definition MUST be defined in credentialSchema', async function() { | ||
| /*If a credential definition is being used, the credential | ||
| definition MUST be defined in the credentialSchema property, | ||
| so that it can be used by all parties to perform various cryptographic |
There was a problem hiding this comment.
| so that it can be used by all parties to perform various cryptographic | |
| so all parties can use it to perform various cryptographic |
There was a problem hiding this comment.
@clehner -- If #127 (comment) is asking me about the above rephrasing, then I would definitely change it here, and if such editorial change can still be made in the other doc, then I would change it there as well.
|
The comment as it is now uses the wording from VC Data Model:
https://www.w3.org/TR/vc-data-model/#zero-knowledge-proofs
Maybe it is better to keep it the same, so it is easier to find the correspondence with the spec? Or do you think it should be changed in vc-data-model as well?
|
Update the test suite to correspond with changes in w3c/vc-data-model#818 to normatives statements about ZKPs.
I added the skipped tests as I am not sure how to test those.
Possibly the one about credentialSchema could be addressed with a new optional section to test ZKP types that require credentialSchema. But there is already a section testing credentialSchema.
Several tests related to credentialSchema are removed from the ZKP section, but similar tests are still present in the credentialSchema section (
test/vc-data-model-1.0/20-schema.js).The requirement that a verifiable credential "MUST contain all information necessary to verify..." could perhaps be tested with a contrived example where the signature input contains some data not present in the verifiable credential. But I don't know if that is representable in the VC Data Model.