Add explicit arguments to codec algorithms. #111
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously the algorithms assume that any mentioned interface attribute is implicitly belonging to the codec interface shared by the method that invoked the algorithm. Unfortunately, that meant none of the bikeshed autolinking picked up on usage of the interface attributes within the algorithm. Now, all interface attributes are explicitly mentioned when invoking the algorithm, so the linking picks up on this. I do think it turns out pretty verbose and hard to read :/. Still considering other approaches.
|
@chcunningham - can you join the WICG to appease the IPR bots? |
|
Re: IPR - I think I'm already joined? When I go to https://www.w3.org/community/wicg/join it says "You are already a participant in this group." In an earlier PR the bots were happy on one commit, then unhappy on the next: https://github.com/WICG/web-codecs/pull/109/commits Nothing changed on my end that I'm aware of. I filed w3c/ash-nazg#188 |
|
Closing in favor of #112 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NOTE: I'm not asking to merge this. I think its hard to read. I'm working
on an alternative impl (less parameterization, more duplication). We
should compare them and decide which is prefered. I'll reply here when
option 2 is ready.
Previously the algorithms assume that any mentioned interface attribute
is implicitly belonging to the codec interface shared by the method that
invoked the algorithm. Unfortunately, that meant none of the bikeshed
autolinking picked up on usage of the interface attributes within the
algorithm.
Now, all interface attributes are explicitly mentioned when invoking the
algorithm, so the linking picks up on this.
I do think it turns out pretty verbose and hard to read :/.
Preview | Diff