-
Notifications
You must be signed in to change notification settings - Fork 143
Add SVC modes and metadata #187
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Note that this is not intended to address #161 or #182. I expect we may provide a separate mechanism for mutable metadata to address those. Here, "metadata" refers to an encoder output. It describes a chunk, but it is intentionally not part of the chunk interface, as I want to avoid folks thinking that they need to describe various SVC metadata when giving chunks to the decoder (the only requirement when feeding SVC to the decoder is that you do so in decode order). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR only includes the TID for metadata, not the other things discussed in https://docs.google.com/document/d/1O6kxAQPLWhCRHkH-6zutcqEUOUWRS6NFM2CQAvi1VTg/ Is this to focus on the things required for H.264/AVC with temporal scalability? Wondering if it would make sense to put it all in now.
That's right (focus on H.264). I will send a follow up PR shortly that adds the other fields. My aim is to prioritize this one, as it includes the breaking changes for the encoder output callback interface, and split off the less urgent discussion of the other metadata pieces. |
Editors call: interface changes LGTM. Defer to @aboba on review of SVC particulars |
Also adds descriptions for metdata members.
Latest just fills in the algo steps needed to provide the metadata as previously discussed. Lets run through it quickly on tomorrows call. |
Editors call: LGTM, merge it |
SHA: d39fda0 Reason: push, by @chcunningham Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
SHA: d39fda0 Reason: push, by @chcunningham Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
SHA: d39fda0 Reason: push, by @chcunningham Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
SHA: d39fda0 Reason: push, by @tguilbert-google Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
SHA: d39fda0 Reason: push, by @tguilbert-google Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
SHA: d39fda0 Reason: push, by @tguilbert-google Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Adds VideoEncoderConfig.scalabilityMode to configure SVC encoding.
Adds Encoded*ChunkMetadata interfaces to encoder output callbacks where chunk metadata is provided to describe SVC (currently just temporalLayerId) alognside the *DecodingConfig. Additional metadata fields would be added later.
Fixes #85 #40 #9
Preview | Diff