Skip to content

Define internal slots as backing for VideoFrame attributes #190

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 23, 2021
Merged

Define internal slots as backing for VideoFrame attributes #190

merged 2 commits into from
Apr 23, 2021

Conversation

chcunningham
Copy link
Collaborator

@chcunningham chcunningham commented Apr 23, 2021 •
edited by pr-preview bot
Loading

Adds slots for all VideoFrame attributes and updates all references to attributes to instead reference the slots. This is an increment step toward resolving #184.

Preview | Diff

@chcunningham
Define internal slots as backing for VideoFrame attributes.
6ebb060 
Purely mechanical change (behavior and interface unchanged). This is an
increment step toward resolving #184.
@chcunningham
Merge remote-tracking branch 'origin/main' into videoframe_slots
6a09f88
@chcunningham
Copy link
Collaborator Author

@padenot @aboba - This is a purely mechanical change (behavior and interface unchanged) to add slots for attributes, so I'll go ahead and merge.

Note that I updated the VideoFrame constructor steps to correctly initialize the slots, but most of these steps are actually re-written by PR #167.

@chcunningham chcunningham merged commit a4ef61b into main Apr 23, 2021
@chcunningham chcunningham deleted the videoframe_slots branch June 2, 2021 03:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@chcunningham