Add orientation to VideoFrame #840
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
It's a Big Mess, see #351 (comment): source and destination can decide to take the orientation into account, or disregard it. Sometimes the orientation is from the image, sometimes from style. Open the test case in Chromium/Gecko/WebKit browsers for extra fun. |
padenot
approved these changes
Oct 15, 2024
Collaborator
padenot
left a comment
padenot
left a comment
There was a problem hiding this comment.
Looks good modulo (ha!) a small comment that I'd like fixed before merging.
Contributor
|
I'd mention orientation and flip in "9.4.8. Rendering" |
Djuffin
approved these changes
Oct 18, 2024
Contributor
Author
Done. |
github-actions bot
added a commit
that referenced
this pull request
Oct 31, 2024
SHA: 3d99c2b Reason: push, by sandersdan Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds
rotationandfliptoVideoFrameandVideoFrameconstructorinitdictionaries, as described in #351 (comment).Does not include any changes to
VideoDecoder,VideoEncoder, orImageDecoder.I do not allow buffer-initialized
VideoFrames to end up with orientations other than requested, which differs from the proposal slightly, but is probably more obvious for developers.I assume that
CanvasandImageBitmapsources do not have natural orientations. I do not know if this is reasonable.There is handwaving around the natural orientation of
ImageElementsources, as I did not find any spec text that describes how EXIF orientation is actually handled.Preview | Diff