Implement orientation support for VideoEncoder. #884
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This implements the algorithm as discussed in the Media WG: * Orientation is locked-in upon the first call to encode(). * Mismatched orientation will trigger a non-fatal error by throwing an exception during encode(). * The orientation of the first frame is emitted on the VideoDecoderConfig attached to EncodedVideoChunkMetadata. Fixes: #351
Djuffin
approved these changes
Mar 14, 2025
padenot
reviewed
Mar 14, 2025
padenot
approved these changes
Mar 14, 2025
Co-authored-by: Paul Adenot <[email protected]>
github-actions bot
added a commit
that referenced
this pull request
Mar 14, 2025
SHA: c683ac1 Reason: push, by dalecurtis Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements the algorithm as discussed in the Media WG:
Fixes: #351
Preview | Diff