Skip to content

2023 note2 updates2 #477

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 22, 2023
Merged

2023 note2 updates2 #477

merged 2 commits into from
May 22, 2023

Conversation

danielpeintner
Copy link
Contributor

@danielpeintner danielpeintner commented May 15, 2023

Preview

NOTE: All (some?) of the fixes should go into the main note as well in a follow-up PR

fixes #475

Bad value 100% for attribute width on element img: Expected a digit but saw % instead.
@danielpeintner danielpeintner marked this pull request as draft May 15, 2023 15:56
@danielpeintner
Copy link
Contributor Author

Note: I fixed all HTML errors expect one that appears often "Duplicate ID idl-def-wot."

I think it comes from the WebIDL and I am not sure how to fix that... shall we just remove the other IDs? I am pretty sure that breaks things...

image

@danielpeintner danielpeintner marked this pull request as ready for review May 19, 2023 09:24
@danielpeintner
Copy link
Contributor Author

danielpeintner commented May 19, 2023

@ashimura the remaining issue with duplicate id "idl-def-wot" is coming from ReSpec. We in our html do not create this ID, please have a look at https://github.com/w3c/wot-scripting-api/blob/main/index.html. You will not find "idl-def-wot"..

It comes from the WebIdl where we use partial namespace WOT like in

partial namespace WOT {
  Promise<ConsumedThing> consume(ThingDescription td);
};

or

partial namespace WOT {
  Promise<ExposedThing> produce(ExposedThingInit init);
};

or

partial namespace WOT {
  Promise<ThingDiscoveryProcess> exploreDirectory(USVString url,
      optional ThingFilter filter = {});
};

How can we move on?
@zolkis can we define it differently?

EDIT: Can/shall we open a ReSpec bug report?

@danielpeintner danielpeintner mentioned this pull request May 19, 2023
@zolkis
Copy link
Contributor

zolkis commented May 19, 2023

Those definitions are correct, according to https://webidl.spec.whatwg.org/#dfn-partial-namespace

But we can also collate all those definitions in the first one, i.e. without any partial definitions.

@danielpeintner
Copy link
Contributor Author

I created https://github.com/w3c/respec/issues/4447, maybe there is a simple solution/fix for it.

@relu91
Copy link
Member

relu91 commented May 22, 2023

Call 22/05/2023:

  • @ashimura can talk with the webmaster and move ahead with the publication. Nonetheless, in the future, we need to fix the error (in respec) or re-evaluate the usage of partial definition. Note that in the Full WebIDL, we have a bunch of partial definitions that are not really needed (we can define everything in the single namespace).
  • we are merging this for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pubrules checker hangs for current published version at 35/37
3 participants