Skip to content

Add 'Choose the Appropriate WebIDL Construct for Data and Behavior' #567

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 24 commits into from
Jul 2, 2025
Merged

Add 'Choose the Appropriate WebIDL Construct for Data and Behavior' #567

merged 24 commits into from
Jul 2, 2025

Conversation

marcoscaceres
Copy link
Contributor

@marcoscaceres marcoscaceres commented Mar 25, 2025 •
edited by pr-preview bot
Loading

Closes #11

Preview | Diff

martinthomson
martinthomson reviewed Mar 25, 2025
View reviewed changes
martinthomson
martinthomson reviewed Mar 25, 2025
View reviewed changes
Copy link
Contributor

@martinthomson martinthomson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need to use <div class=example more.

martinthomson
martinthomson reviewed Mar 25, 2025
View reviewed changes
Copy link
Contributor

@martinthomson martinthomson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lots more typos to fix throughout, but concentrating on high-level stuff.

martinthomson
martinthomson reviewed Mar 25, 2025
View reviewed changes
@jyasskin
Copy link
Contributor

Is this meant to close #11?

@jyasskin jyasskin force-pushed the interfaces-dicts-namespaces branch from f982070 to d27fcae Compare May 2, 2025 03:51
martinthomson
martinthomson reviewed Jun 3, 2025
View reviewed changes
@jyasskin jyasskin marked this pull request as draft June 16, 2025 17:25
marcoscaceres
marcoscaceres commented Jun 17, 2025
View reviewed changes
marcoscaceres
marcoscaceres commented Jun 17, 2025
View reviewed changes
marcoscaceres
marcoscaceres commented Jun 17, 2025
View reviewed changes
marcoscaceres
marcoscaceres commented Jun 17, 2025
View reviewed changes
martinthomson
martinthomson reviewed Jun 17, 2025
View reviewed changes
marcoscaceres
marcoscaceres commented Jun 23, 2025
View reviewed changes
marcoscaceres and others added 2 commits June 23, 2025 11:58
marcoscaceres
marcoscaceres commented Jun 23, 2025
View reviewed changes
@marcoscaceres marcoscaceres marked this pull request as ready for review June 23, 2025 02:08
martinthomson
martinthomson previously requested changes Jun 23, 2025
View reviewed changes
Copy link
Contributor

@martinthomson martinthomson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is good stuff, but I had some difficulty translating it to the idioms of the document. Needs work.

@marcoscaceres @martinthomson
Update index.bs
968192e 
Co-authored-by: Martin Thomson <[email protected]>
marcoscaceres and others added 5 commits June 23, 2025 13:08
@marcoscaceres @martinthomson
Apply suggestions from code review
47fe0c1 
Co-authored-by: Martin Thomson <[email protected]>
@marcoscaceres @martinthomson
Update index.bs
30a9917 
Co-authored-by: Martin Thomson <[email protected]>
@marcoscaceres @martinthomson
Update index.bs
48fbf61 
Co-authored-by: Martin Thomson <[email protected]>
@marcoscaceres @martinthomson
Update index.bs
0d0da0a 
Co-authored-by: Martin Thomson <[email protected]>
@marcoscaceres @martinthomson
Apply suggestions from code review
5d1db6b 
Co-authored-by: Martin Thomson <[email protected]>
jyasskin
jyasskin reviewed Jun 23, 2025
View reviewed changes
@martinthomson @jyasskin
Bikeshed is too picky
ca1804e 
Co-authored-by: Jeffrey Yasskin <[email protected]>
martinthomson
martinthomson reviewed Jun 24, 2025
View reviewed changes
marcoscaceres
marcoscaceres commented Jul 1, 2025
View reviewed changes
marcoscaceres
marcoscaceres commented Jul 1, 2025
View reviewed changes
marcoscaceres
marcoscaceres commented Jul 1, 2025
View reviewed changes
marcoscaceres
marcoscaceres commented Jul 1, 2025
View reviewed changes
marcoscaceres
marcoscaceres commented Jul 1, 2025
View reviewed changes
marcoscaceres
marcoscaceres commented Jul 1, 2025
View reviewed changes
marcoscaceres
marcoscaceres commented Jul 1, 2025
View reviewed changes
martinthomson
martinthomson reviewed Jul 1, 2025
View reviewed changes
index.bs Outdated
* `navigator.geolocation` - The `Geolocation` interface of the Geolocation specification.
* `navigator.permissions` - The `Permissions` interface of the Permissions specification.

Pseudo-namespaces are useful for when, as a spec author, you need access to "this" particular instance
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Pseudo-namespaces are useful for when, as a spec author, you need access to "this" particular instance
Pseudo-namespaces are useful for when, as a spec author,
you need to refer to a specific instance of a thing
(such as the permissions that apply to a specific browsing context, for `navigator.permissions`)
even if that thing does not have any visible state exposed to the page.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added suggestion.

marcoscaceres
marcoscaceres commented Jul 1, 2025
View reviewed changes
@martinthomson martinthomson dismissed their stale review July 1, 2025 23:59

Let's go.

@martinthomson martinthomson merged commit c757c94 into main Jul 2, 2025
1 check passed
@martinthomson martinthomson deleted the interfaces-dicts-namespaces branch July 2, 2025 00:00
github-actions bot added a commit that referenced this pull request Jul 2, 2025
@marcoscaceres @github-actions
Add 'Choose the Appropriate WebIDL Construct for Data and Behavior' (#…
a7442a2 
…567)

SHA: c757c94
Reason: push, by martinthomson

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jyasskin jyasskin jyasskin left review comments

@martinthomson martinthomson martinthomson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

WebIDL interfaces should only be used when you have both data and behavior
3 participants
@marcoscaceres @jyasskin @martinthomson