Don't require action within a Promise reaction microtask. #570
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jyasskin
reviewed
May 8, 2025
There was a problem hiding this comment.
Thanks @jan-ivar. I've left a bunch of suggestions for @martinthomson to review, and you're welcome to apply any that you agree with or make other changes in response, but we can also take it from here.
Co-authored-by: Jeffrey Yasskin <[email protected]>
Comment on lines
+1986
to
+1989
| If developer-supplied code needs to be able to call <code>event.{{Event/preventDefault()}}</code> | ||
| or choose a response object with | ||
| <code>fetchEvent.{{FetchEvent/respondWith()}}</code>, | ||
| it needs to be a callback rather than a reaction passed to <code>Promise.{{Promise/then()}}</code>. |
There was a problem hiding this comment.
Is this a good example or a bad one?
There was a problem hiding this comment.
It's probably ingrained at this point. Whether it's a good pattern or not might be debatable. The last place I personally encountered it was https://w3c.github.io/webrtc-extensions/#dfn-icecandidatepairremove (though our motivation there was finding a manner of interfering with the ICE agent that the most people could stomach).
Co-authored-by: Martin Thomson <[email protected]>
Co-authored-by: Martin Thomson <[email protected]>
|
Thanks for all the feedback, this is looking much better! |
jyasskin
approved these changes
May 18, 2025
Co-authored-by: Jeffrey Yasskin <[email protected]>
github-actions bot
added a commit
that referenced
this pull request
May 19, 2025
SHA: 8b0f2a8 Reason: push, by martinthomson Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #342.
Preview (#sync-callbacks) (#promises-and-reacti…) | Diff