Skip to content

Conversation

@ntrrgc
Copy link
Contributor

@ntrrgc ntrrgc commented Oct 3, 2025

This patch adds parsing of inner AOT and extension_sampling_frequency to SBR and PS when they're hierarchically signalled.

@wader
Copy link
Owner

wader commented Oct 3, 2025

Thanks! looks like no existing test covers this. Could you add a test case? there is some instructions in the dev docs how to otherwise feel free to just ask

@ntrrgc
Copy link
Contributor Author

ntrrgc commented Oct 3, 2025

make test fails in my computer but I still managed to make a test and run it with go test ./format -run TestFormats/mpeg.

@wader
Copy link
Owner

wader commented Oct 3, 2025

Aha is it make testcli that fails? that is the expect based cli tests that are a bit flaky in some envs unfortunately, ignore them. If make testgo and CI is happy I'm happy.

CI is happy and test looks good so I'm fine merging if you feel ready?

This patch adds parsing of inner AOT and extension_sampling_frequency to
SBR and PS when they're hierarchically signalled.
@ntrrgc
Copy link
Contributor Author

ntrrgc commented Oct 6, 2025

Indeed make testgo is happy and it's make testcli which has some problem with expect.

@wader wader merged commit 34532ce into wader:master Oct 6, 2025
5 checks passed
@wader
Copy link
Owner

wader commented Oct 6, 2025

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants