Skip to content

Add nerdctl support #561

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

darktohka
Copy link

Right now, there is no support for nerdctl, a pretty nifty container CLI for containerd: https://github.com/containerd/nerdctl

This PR adds support for a new image source: --source nerdctl

This image source is supported on all OSes, nerdctl has support for Linux, Windows and Darwin as well.

Nerdctl saves images using nerdctl image save <id>. If this errors (the image may not exist), nerdctl pull <id> is tried to pull the image if possible.

Nerdctl can also build images the same way as the Docker CLI (nerdctl build --iidfile)

@polarathene
Copy link
Contributor

You may need to rebase your PRs due to the recent PR syncing a fork back to dive, maintainer of dive is active again on the project so this would be a good time to have your PRs rebased for review.

@wagoodman
Copy link
Owner

Thanks for the contribution! I'm all for supporting containerd, though I'm about to put in a refactor code responsible for fetching images to use anchore/stereoscope in #569 , which already has support for containerd, so it might not be worth the time trying to rebase this PR yet. I'll close this PR in conjunction with the new PR that will bring in stereoscope.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants