Skip to content

Conversation

@iGio90
Copy link
Contributor

@iGio90 iGio90 commented Jul 18, 2017

Reference to: #9

Needs verification for the standard usage with XML:

  • If someone can test it with standard usage as it was without this PR, so by inflating using XML layout would be awesome, otherwise a bit more patience and i'll be free to test it in 7/8 hours.
    I can't see anything that could break the usage with XML. Dynamic is working fine as I'm actually using it on a corporate project.

Reference to: wajahatkarim3#9

Needs verification for the standard usage with XML:
- If someone can test it with standard usage as it was without this PR, so by inflating using XML layout would be awesome, otherwise a bit more patience and i'll be free to test it in 7/8 hours.
I can't see anything that could break the usage with XML. Dynamic is working fine as I'm actually using it on a corporate project.
@iGio90
Copy link
Contributor Author

iGio90 commented Jul 18, 2017

There is a little problem with this that just came to my mind. I need to add a couple of lines ^^

@wajahatkarim3 wajahatkarim3 self-assigned this Jul 19, 2017
@wajahatkarim3 wajahatkarim3 modified the milestone: v1.0.1 milestone Jul 19, 2017
@wajahatkarim3 wajahatkarim3 merged commit 19023e4 into wajahatkarim3:master Nov 7, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants