Skip to content

Implemented max log file size with truncation.#1105

Merged
walkor merged 2 commits into
walkor:masterfrom
akotulu:master
Jul 31, 2025
Merged

Implemented max log file size with truncation.#1105
walkor merged 2 commits into
walkor:masterfrom
akotulu:master

Conversation

@akotulu
Copy link
Copy Markdown
Contributor

@akotulu akotulu commented Jun 18, 2025

Our projects use file logging and atm logs have grown to ~18GB, so implemented file max size with half way truncation.

@akotulu
Copy link
Copy Markdown
Contributor Author

akotulu commented Jun 18, 2025

Found few corner cases, fixed those.

@akotulu
Copy link
Copy Markdown
Contributor Author

akotulu commented Jul 25, 2025

Will this feature be merged to master or I need to do a patch file for it?

@joanhey
Copy link
Copy Markdown
Contributor

joanhey commented Jul 25, 2025

I'm not the best for that.

But I think that this job is for the OS, perhaps with the help of the app (not necessarily) .

@akotulu
Copy link
Copy Markdown
Contributor Author

akotulu commented Jul 26, 2025

Well managing log files with aka logrotate isn't possible for all the solutions. Our micro services have each a WS server included and deploy generates each time a unique directory for rollback. So this would become a nightmare to manage. Most of the programs manage log files internally.

@joanhey
Copy link
Copy Markdown
Contributor

joanhey commented Jul 26, 2025

OK
But why this internal solution, and not an external lib for that ?

By default the actual, if set another log engine, use it !!

@walkor walkor merged commit 36700b8 into walkor:master Jul 31, 2025
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants