Implemented max log file size with truncation.#1105
Merged
Conversation
Contributor
Author
|
Found few corner cases, fixed those. |
Contributor
Author
|
Will this feature be merged to master or I need to do a patch file for it? |
Contributor
|
I'm not the best for that. But I think that this job is for the OS, perhaps with the help of the app (not necessarily) . |
Contributor
Author
|
Well managing log files with aka |
Contributor
|
OK By default the actual, if set another log engine, use it !! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Our projects use file logging and atm logs have grown to ~18GB, so implemented file max size with half way truncation.