MQTT connection error handling #3495
Closed
+40
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johnhe4
commented
Nov 12, 2025
| goto send_reason_and_close; | ||
| case 5: | ||
| par->reason = LMQCP_REASON_UNSUPPORTED_PROTOCOL + | ||
| par->conn_rc - 1; |
Contributor
Author
There was a problem hiding this comment.
I'm guessing this logic used to work at one point? Maybe the MQTT error code enum was updated to support 5.0 errors and that's where this broke.
Member
|
Thanks, it's pushed on main. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Playing with the MQTT client led to some incorrect error handling. For example, if the credentials were invalid, or the protocol was not supported by the server, the error log only showed
Parsing packet failedand would not invoke the client callback. These changes attempt to address that.