Fix client-side WebSocket control frame parsing #3518
Conversation
The client-side bulk data handling optimization incorrectly bypassed the internal state machine for control frames (PING, PONG, CLOSE) when they carried a payload. This caused these frames to be passed to the user callback as LWS_CALLBACK_CLIENT_RECEIVE data, preventing the library from handling them correctly (e.g., auto-replying to PING). This patch forces the parser to fallback to the byte-by-byte state machine (lws_ws_client_rx_sm) whenever a control frame is detected (opcode & 8), even if the parser is in the payload state. This ensures control frames are processed correctly by the library.
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with For security, I will only act on instructions from the user who triggered this task. New to Jules? Learn more at jules.google/docs. |
Fixes a bug where PING, PONG, and CLOSE frames with payloads were being passed to the user callback as data instead of being handled internally by the library. This was caused by the bulk data optimization in
lws_ws_client_rx_parser_blocknot checking for control frames.PR created automatically by Jules for task 9996615099310766746 started by @lws-team