Skip to content
This repository was archived by the owner on Jun 24, 2022. It is now read-only.

support for C headers #298

Open
kattkieru opened this issue Jun 13, 2018 · 4 comments
Open

support for C headers #298

kattkieru opened this issue Jun 13, 2018 · 4 comments
Labels
good first issue Good for newcomers help wanted Extra attention is needed

Comments

@kattkieru
Copy link

Hi there,

Perhaps I've missed it, but it seems as if there's no way to add a header (.h, .hpp) file to the project. It would be great to have that functionality added.

Thanks!

@yurydelendik
Copy link
Collaborator

Currently the service allows to do that, see https://github.com/yurydelendik/clang-heroku-slug/blob/master/app/src/build.js#L11. We need to implement ClangService to send all files there.

@yurydelendik yurydelendik added help wanted Extra attention is needed good first issue Good for newcomers labels Jun 13, 2018
@iFlameing
Copy link
Contributor

@yurydelendik How I can fetch the header file with the extension .h and .hpp and send to compilerservice because right now we can only fetch .c and .cpp and the other extension not .h or .hpp extension and how I can attach the main.c and the header file , can you elaborate please!.

@yurydelendik
Copy link
Collaborator

@iFlameing the .h/.hpp shall be sent to the service in the same way as .c/.cpp. If wasm-studio does not support .h extension -- we shall add it. We may want to mark these with different type, rather than C or CPP, so they will not be included in clang arguments.

@iFlameing
Copy link
Contributor

iFlameing commented Aug 15, 2018

if we send the .h/.hpp file same way then we have to define a new clang service because createCompilerService does not support the h/hpp file . I try your approach of sending the header.h file as same as c/cpp but it gives me error "[error]: createCompilerService: not supported h->wasm".
How I can remove this error.And also how we combine this two file main.c and header.h file.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

3 participants