Skip to content

Installers.installMarked not refreshing text after marked.js has loaded #13

@wbillingsley

Description

@wbillingsley

Installers.installMarked dynamically installs marked.js into the page and supplies a Markup instance that can be used as a given instance. When the script is loaded, it calls Update on the root element or site.

However, the Markup instance it provides don't refresh with the update - this is because Markup.Fixed and Markup.Updatable both check to see if the string has changed before they alter their output. As the input string has not change, the version before the script loaded does not end up getting update.

To fix this, I propose altering Markup to be a trait. This will allow installMarked to generate a placeholder element that will be replaced when the update is next called.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions