Skip to content

set json-object-type to alist, as expected by direnv--summarise-changes #72

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 11, 2021
Merged

set json-object-type to alist, as expected by direnv--summarise-changes #72

merged 1 commit into from
Oct 11, 2021

Conversation

collares
Copy link
Contributor

@collares collares commented Oct 10, 2021 •
edited
Loading

Using emacs-direnv with lean-mode, I want to run direnv-update-environment before a particular function runs by doing

(advice-add 'lean-setup-rootdir :before #'direnv-update-environment)

but that function is called in a scope where json-object-type is set to 'plist, which breaks direnv--summarise-changes.

@wbolster wbolster merged commit c4bbbce into wbolster:master Oct 11, 2021
@wbolster
Copy link
Owner

mutable global state 🙄 what can go wrong…

thanks, merged!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wbolster wbolster wbolster approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@collares @wbolster