Rename bazel to bazel-rules #125
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `bazel` executable installed by the official packaging is a shell script. One of the things it does is look for `$PWD/tools/bazel` and try to run that, presumably to allow for easy customization. Since we vendor build-tools in as `tools/` almost everywhere, we cannot have a directory named `bazel` as the `bazel` CLI will try to execute `tools/bazel` and fail.
awh
approved these changes
Jan 15, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
bazelexecutable installed by the official packaging is a shell script.One of the things it does is look for
$PWD/tools/bazeland try to run that,presumably to allow for easy customization.
Since we vendor build-tools in as
tools/almost everywhere,we cannot have a directory named
bazelas the
bazelCLI will try to executetools/bazeland fail.