Skip to content

Conversation

@SoonIter
Copy link
Member

@SoonIter SoonIter commented Oct 27, 2025

Summary

before

image

after

image

Related Issue

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

Copilot AI review requested due to automatic review settings October 27, 2025 09:21
@netlify
Copy link

netlify bot commented Oct 27, 2025

Deploy Preview for rspress-v2 ready!

Name Link
🔨 Latest commit a5c3a5b
🔍 Latest deploy log https://app.netlify.com/projects/rspress-v2/deploys/68ff3ce39e006a00086be2e4
😎 Deploy Preview https://deploy-preview-2688--rspress-v2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@SoonIter SoonIter changed the title fix(theme/code): code font-size should be different fix(theme/code): fix the table code font-size and separate inline-code-block and code-block Oct 27, 2025
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This pull request refactors code block and inline code styling by migrating common text formatting rules from the general document styles to the CodeBlock component. The changes consolidate styling rules and introduce a uniform font-size for inline code elements.

Key Changes:

  • Migrated shared text formatting properties (white-space, word-spacing, hyphens, etc.) from doc.scss to CodeBlock component
  • Simplified inline code font-size rules by replacing multiple selectors with a single 0.875em value
  • Removed special font-size handling for heading code elements

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File Description
packages/theme-default/src/components/DocContent/doc.scss Removed migrated text formatting rules and simplified inline code font-size selectors
packages/theme-default/src/components/CodeBlock/index.scss Added text formatting properties previously defined in doc.scss

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@SoonIter SoonIter requested a review from Timeless0911 October 27, 2025 09:42
@SoonIter SoonIter enabled auto-merge (squash) October 27, 2025 11:32
@SoonIter SoonIter merged commit 3f1379d into main Oct 27, 2025
8 checks passed
@SoonIter SoonIter deleted the syt/fix-table-style-test branch October 27, 2025 11:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants