Skip to content

Conversation

@chenjiahan
Copy link
Member

Summary

Replace all references to the old PNG logo with the new SVG version from the assets.rspack.rs domain.

Related Issue

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

Copilot AI review requested due to automatic review settings November 10, 2025 06:11
@netlify
Copy link

netlify bot commented Nov 10, 2025

Deploy Preview for rspress-v2 ready!

Name Link
🔨 Latest commit f31a31a
🔍 Latest deploy log https://app.netlify.com/projects/rspress-v2/deploys/6912e88b1925340008234313
😎 Deploy Preview https://deploy-preview-2737--rspress-v2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates all Rspress logo references to use a consistent SVG format from a centralized CDN location. The changes replace various PNG and WebP logo references with a single SVG URL across configuration files, documentation, and test fixtures.

  • Standardizes logo format from PNG/WebP to SVG for better scalability
  • Consolidates logo URLs to use assets.rspack.rs CDN
  • Updates test expectations to match the new logo URL

Reviewed Changes

Copilot reviewed 8 out of 9 changed files in this pull request and generated no comments.

Show a summary per file
File Description
website/rspress.config.ts Updated site logo and icon to use SVG format
website/docs/zh/index.md Changed hero image to use CDN-hosted SVG logo
website/docs/zh/fragments/builtin-components.mdx Updated Badge component examples to use SVG logo
website/docs/public/rspress-logo.webp File deleted (replaced by CDN asset)
website/docs/en/index.md Changed hero image to use CDN-hosted SVG logo
website/docs/en/fragments/builtin-components.mdx Updated Badge component examples to use SVG logo
e2e/fixtures/inline-markdown/index.test.ts Updated test expectation for new SVG logo URL
e2e/fixtures/inline-markdown/doc/index.mdx Updated feature icon to use SVG logo
e2e/fixtures/basic/rspress.config.ts Updated custom nav content to use SVG logo

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@github-actions
Copy link
Contributor

github-actions bot commented Nov 10, 2025

Rsdoctor Bundle Diff Analysis

Metric Current Baseline Change
📊 Total Size 14.3 MB 14.3 MB 3.4 KB (0.0%)
📄 JavaScript 13.7 MB 13.7 MB 3.4 KB (0.0%)
🎨 CSS 108.5 KB 108.5 KB 0 B (0.0%)
🌐 HTML 0 B 0 B N/A
📁 Other Assets 494.2 KB 494.2 KB 0 B (0.0%)

A detailed bundle diff analysis has been generated using Rsdoctor. You can download and view the interactive HTML report from the workflow artifacts.

📦 Download Link: Download Bundle Diff Report

Generated by Rsdoctor Action

Timeless0911
Timeless0911 previously approved these changes Nov 10, 2025
@SoonIter SoonIter merged commit f075fea into main Nov 11, 2025
9 checks passed
@SoonIter SoonIter deleted the svg_logo_1110 branch November 11, 2025 08:00
@SoonIter
Copy link
Member

image There seem to be some issues with the outline, maybe the text color is set by default.

@chenjiahan
Copy link
Member Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants