fix(route): should be compatiable to lowercase routePath #2776
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for rspress-v2 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Contributor
Rsdoctor Bundle Diff Analysis📁 webPath:
Generated by Rsdoctor GitHub Action |
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds case-insensitive route matching to handle scenarios where URLs may use different casing. The implementation converts route paths to lowercase during normalization and comparison.
Key changes:
- Modified
normalizeRoutePathto convert paths to lowercase for case-insensitive matching - Updated
matchPath,pathnameToRouteService, andisActivefunctions to use normalized paths for comparison - Added comprehensive test coverage for case-insensitive matching scenarios
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| packages/runtime/src/route.ts | Implements case-insensitive route matching by adding .toLowerCase() to path normalization and updating all matching functions to use normalized paths |
| packages/runtime/src/route.test.ts | Adds test cases validating case-insensitive matching behavior across all route matching functions |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Timeless0911
approved these changes
Nov 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
fix(route): should be compatiable to lowercase routePath
Related Issue
Checklist