fix(theme): section-header margin-top wrong selector #2782
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for rspress-v2 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR attempts to fix the margin-top styling for section headers in the sidebar by moving the reset logic from the SidebarSectionHeader component to the SidebarGroup component.
Key Changes
- Removed the
:first-of-typeselector from.rp-sidebar-section-headerthat setmargin-top: 0 - Added a
:first-childselector to.rp-sidebar-groupto setmargin-top: 0
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| packages/core/src/theme/components/Sidebar/SidebarSectionHeader.scss | Removes the first-of-type margin reset rule from section headers |
| packages/core/src/theme/components/Sidebar/SidebarGroup.scss | Adds a first-child margin reset rule to sidebar groups |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
Rsdoctor Bundle Diff Analysis📁 webPath:
📦 Download Diff Report: web Bundle Diff Generated by Rsdoctor GitHub Action |
SoonIter
force-pushed
the
syt/fix-header
branch
from
d2067fd to
cde0ee6
Compare
SoonIter
changed the title
Timeless0911
approved these changes
Nov 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
fix(theme): section-header margin-top
Related Issue
Checklist