Skip to content

Conversation

@SoonIter
Copy link
Member

Summary

chore(theme/doc): add border to inline text code

Related Issue

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

Copilot AI review requested due to automatic review settings November 20, 2025 12:06
@netlify
Copy link

netlify bot commented Nov 20, 2025

Deploy Preview for rspress-v2 ready!

Name Link
🔨 Latest commit de6be74
🔍 Latest deploy log https://app.netlify.com/projects/rspress-v2/deploys/691f0767461b4200078baa95
😎 Deploy Preview https://deploy-preview-2796--rspress-v2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds a border to inline code elements in documentation content by introducing new CSS custom properties for theming and applying them to the code styling.

  • Adds --rp-c-text-code-border CSS variable for light and dark themes
  • Applies the border to inline code elements using the new variable

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
packages/core/src/theme/styles/vars/base-vars.css Defines new CSS variables for inline code border colors in light (semi-transparent) and dark (transparent) themes
packages/core/src/theme/components/DocContent/doc.scss Applies 1px solid border to inline code elements using the new CSS variable

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Timeless0911
Timeless0911 previously approved these changes Nov 20, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Nov 20, 2025

Rsdoctor Bundle Diff Analysis

📁 web

Path: website/doc_build/web/rsdoctor-data.json

Metric Current Baseline Change
📊 Total Size 14.3 MB 14.3 MB -3.2 KB (-0.0%)
📄 JavaScript 13.7 MB 13.8 MB -3.3 KB (-0.0%)
🎨 CSS 109.9 KB 109.8 KB 114.0 B (0.1%)
🌐 HTML 0 B 0 B N/A
📁 Other Assets 497.3 KB 497.3 KB 0 B (0.0%)

📦 Download Diff Report: web Bundle Diff

Generated by Rsdoctor GitHub Action

@SoonIter SoonIter marked this pull request as draft November 20, 2025 12:15
@SoonIter SoonIter marked this pull request as ready for review November 20, 2025 12:22
@SoonIter SoonIter merged commit f351def into main Nov 21, 2025
9 checks passed
@SoonIter SoonIter deleted the syt/add-border-text-code branch November 21, 2025 04:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants