fix(theme): plugin-preview should hide the toc #2803
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for rspress-v2 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes the table of contents (TOC) visibility issue in the plugin-preview theme by hiding the outline when a preview device is displayed. The changes simplify the previous implementation that dynamically adjusted padding based on window width, replacing it with a simpler approach that directly hides the TOC outline element.
Key changes:
- Removed dynamic padding logic that adjusted based on window size
- Added inline style to hide the TOC outline when preview device is shown
- Renamed CSS classes from unprefixed (e.g.,
fixed-device) torp-prefixed (e.g.,rp-fixed-device) for consistency - Improved test fixture documentation structure with proper headings
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| packages/plugin-preview/static/global-components/Device.tsx | Simplified outline hiding logic by removing useWindowSize/useEffect hooks and adding inline style to hide TOC; updated class names to use rp- prefix |
| packages/plugin-preview/static/global-components/Device.css | Updated CSS class names from unprefixed to rp- prefixed for consistency |
| packages/plugin-preview/static/global-components/DemoBlock.tsx | Updated class names from rspress-demo-block to rp-demo-block for consistency |
| packages/plugin-preview/static/global-components/DemoBlock.css | Updated CSS class names to match the new rp- prefixed naming convention |
| e2e/fixtures/plugin-preview/doc/mixed.mdx | Added proper heading structure to test fixture |
| e2e/fixtures/plugin-preview/doc/index.mdx | Added h2 heading to improve test fixture structure |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
Rsdoctor Bundle Diff Analysis📁 webPath:
📦 Download Diff Report: web Bundle Diff Generated by Rsdoctor GitHub Action |
Timeless0911
previously approved these changes
Nov 24, 2025
SoonIter
force-pushed
the
syt/fix-preview-style
branch
from
39d8bde to
f593ba1
Compare
Timeless0911
approved these changes
Nov 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
fix(theme): plugin-preview should hide the toc
Related Issue
Checklist