-
-
Notifications
You must be signed in to change notification settings - Fork 200
fix(plugin-typedoc): allow typedoc plugin interface as usual #2836
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
✅ Deploy Preview for rspress-v2 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR aims to fix the plugin-typedoc to handle absolute entry point paths correctly, particularly addressing Windows path issues. The changes allow users to specify entry points using absolute paths (via path.join(__dirname, ...)) instead of only relative paths.
- Adds path normalization logic to convert absolute entry point paths to relative paths
- Updates test fixtures to use absolute paths with
path.join(__dirname, ...)
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| packages/plugin-typedoc/src/index.ts | Adds path conversion logic to handle both absolute and relative entry points, with a focus on Windows compatibility |
| e2e/fixtures/plugin-typedoc/single/rspress.config.ts | Updates test to use absolute path with path.join(__dirname, ...) |
| e2e/fixtures/plugin-typedoc/multi/rspress.config.ts | Updates test to use absolute paths with path.join(__dirname, ...) for multiple entry points |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Rsdoctor Bundle Diff Analysis📁 webPath:
📦 Download Diff Report: web Bundle Diff Generated by Rsdoctor GitHub Action |
Co-authored-by: Copilot <[email protected]>
|
@copilot fix the windows error |
…ive paths (#2839) Co-authored-by: copilot-swe-agent[bot] <[email protected]> Co-authored-by: SoonIter <[email protected]>
|
|
Summary
fix(plugin-typedoc): allow typedoc plugin interface as usual
Related Issue
Checklist