Skip to content

Conversation

@SoonIter
Copy link
Member

@SoonIter SoonIter commented Dec 3, 2025

Summary

fix(plugin-typedoc): allow typedoc plugin interface as usual

Related Issue

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

Copilot AI review requested due to automatic review settings December 3, 2025 07:47
@netlify
Copy link

netlify bot commented Dec 3, 2025

Deploy Preview for rspress-v2 ready!

Name Link
🔨 Latest commit 9bf4599
🔍 Latest deploy log https://app.netlify.com/projects/rspress-v2/deploys/69301d642eb2130008242a91
😎 Deploy Preview https://deploy-preview-2836--rspress-v2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR aims to fix the plugin-typedoc to handle absolute entry point paths correctly, particularly addressing Windows path issues. The changes allow users to specify entry points using absolute paths (via path.join(__dirname, ...)) instead of only relative paths.

  • Adds path normalization logic to convert absolute entry point paths to relative paths
  • Updates test fixtures to use absolute paths with path.join(__dirname, ...)

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

File Description
packages/plugin-typedoc/src/index.ts Adds path conversion logic to handle both absolute and relative entry points, with a focus on Windows compatibility
e2e/fixtures/plugin-typedoc/single/rspress.config.ts Updates test to use absolute path with path.join(__dirname, ...)
e2e/fixtures/plugin-typedoc/multi/rspress.config.ts Updates test to use absolute paths with path.join(__dirname, ...) for multiple entry points

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@github-actions
Copy link
Contributor

github-actions bot commented Dec 3, 2025

Rsdoctor Bundle Diff Analysis

📁 web

Path: website/doc_build/web/rsdoctor-data.json

📌 Baseline Commit: 085604a8cc | PR: #2838

Metric Current Baseline Change
📊 Total Size 14.5 MB 14.5 MB -3.4 KB (-0.0%)
📄 JavaScript 13.9 MB 13.9 MB -3.4 KB (-0.0%)
🎨 CSS 113.7 KB 113.7 KB 0 B (0.0%)
🌐 HTML 0 B 0 B N/A
📁 Other Assets 499.9 KB 499.9 KB 0 B (0.0%)

📦 Download Diff Report: web Bundle Diff

Generated by Rsdoctor GitHub Action

@SoonIter
Copy link
Member Author

SoonIter commented Dec 3, 2025

@copilot fix the windows error

Copy link
Contributor

Copilot AI commented Dec 3, 2025

@SoonIter I've opened a new pull request, #2839, to work on those changes. Once the pull request is ready, I'll request review from you.

…ive paths (#2839)

Co-authored-by: copilot-swe-agent[bot] <[email protected]>
Co-authored-by: SoonIter <[email protected]>
@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ SoonIter
❌ Copilot
You have signed the CLA already but the status is still pending? Let us recheck it.

@SoonIter SoonIter requested a review from Timeless0911 December 4, 2025 03:48
@Timeless0911 Timeless0911 merged commit e5086ac into main Dec 4, 2025
8 of 9 checks passed
@Timeless0911 Timeless0911 deleted the syt/type-doc branch December 4, 2025 03:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants