fix(cli/eject): fix the component path not right #2896
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for rspress-v2 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Contributor
Rsdoctor Bundle Diff Analysis📁 webPath:
📦 Download Diff Report: web Bundle Diff Generated by Rsdoctor GitHub Action |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds sideEffects configuration for webpack optimization and fixes a bug in the eject functionality where theme components could not be found due to incorrect path resolution in ESM modules.
Key Changes
- Fixed eject functionality by using a constant for the ejected theme path instead of computing it with
__dirname(which doesn't work correctly in ESM) - Added
sideEffects: falseconfiguration for the theme index to enable better tree-shaking - Added path resolution logic for relative theme directories
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| packages/core/src/node/constants.ts | Added EJECTED_THEME constant pointing to the dist/eject-theme directory |
| packages/core/src/node/eject.ts | Fixed eject functionality by using the new EJECTED_THEME constant instead of computing path with __dirname |
| packages/core/src/node/initRsbuild.ts | Added path resolution for relative theme directories, renamed CSS virtual module rule for clarity, and added sideEffects configuration for theme optimization |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
SoonIter
changed the title
SoonIter
force-pushed
the
syt/sideEffects-false
branch
from
cb430ee to
3edd895
Compare
SoonIter
changed the title
Timeless0911
approved these changes
Dec 16, 2025
This was referenced Dec 16, 2025
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
chore: add sideEffects and fix the eject not work
Related Issue
Checklist