-
Notifications
You must be signed in to change notification settings - Fork 16
Add support for KaiOS in downstream browsers #97
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Currently in draft, I'm thinking about making this an opt-in feature behind a flag in both @ai @rviscomi interested to get your thoughts on this. Once this is squared away, we can add a corresponding flag in |
Yes, unfortunatelly, full KaiOS support is much harder than Firefox |
|
SGTM. Should we also update the README in this PR? |
|
Yep, I'll implement the flag and the README changes as part of this PR |
Add KaiOS 2.5 which appears in caniuse Update data file Adds a boolean option to include KaiOS with README and test updates Also adds a fix for frequent permission issue when testing the CLI locally Updating static site fix missing permissions in refresh static Updating static site
|
@ai @rviscomi I'm pretty happy with this as it stands, wdyt? The only thing I'll point out is that this contains versions of KaiOS that aren't reflected in |
|
Yes, Can I Use versions of What versions are in your system? (There are long-term plans to move Browserslist/Autoprefixer to MDN database, but it will require too much work and very painful breaking-changes release). |
The list is here which boils down to:
All of these are derived from the useragents.io database with the exception of 2.5 which I added manually because it's in caniuse and 4.0 because it's in this blog post. That said, the more I look at it the less sure I am that we should include 4.0, as I can't find any other references to KaiOS 4, including on the KaiOS developer site. I've also seen no UserAgent strings in any public dataset. Any strong opinions? The TCL Flip 4 doesn't seem to be available to purchase anywhere that I can find shipping to the UK, but I could see if colleagues in India are able to get hold of one maybe.
This is good to know! |
A very kind YouTubers who reviewed the TCL Flip 4 was kind enough to copy the user agent and send it to me and it confirms that KaiOS 4.0 is indeed based on Gecko 123, so I now feel confident including it in this release. It's now the weekend and a public holiday on Monday in the UK, so I'll get this cleaned up and released on Tuesday 😃 |
|
OK, this passes all tests, and I've checked with a beta version that it doesn't break the supported browsers page because it doesn't use the |
As requested in #96
Versions are based on those pulled from user-agents.io UA strings and forced inclusion of 2.5 based on caniuse including it and 4.0 based on this developer update - no need for a regular update as KaiOS updates very infrequently and can be done manually.