IndexedDB: test a self-removing 'complete' handler. #15822
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
inexorabletash
suggested changes
Mar 13, 2019
| }; | ||
| tx.addEventListener('complete', complete); | ||
| const store = tx.objectStore(STORE); | ||
| store.get(0).addEventListener("success", () => { |
quasicomputational
force-pushed
the
indexeddb-removelistener
branch
from
e74b542 to
4481db9
Compare
|
Thanks for the review! I think I got to all of the suggestions. The one thing I didn't do was to use one of the more framework-y helpers, since this code is testing a buggy event listener implementation, but those helpers add listeners for various things themselves and I'm worried it might wind up not tickling the original bug if it's too far removed from the reproducer. |
inexorabletash
suggested changes
Mar 13, 2019
At least one mocking implementation has a bug that this code tickles - see dumbmatter/fakeIndexedDB#26. Since I'd already reduced it down to a few lines of code, it might as well become a WPT.
quasicomputational
force-pushed
the
indexeddb-removelistener
branch
from
4481db9 to
4f60f62
Compare
|
Ping. I think I've addressed all the comments. I dunno what's up with Taskcluster being red, though. |
|
Ping? |
inexorabletash
approved these changes
Aug 31, 2019
|
Might need a rebase... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At least one mocking implementation has a bug that this code tickles -
see dumbmatter/fakeIndexedDB#26. Since I'd already reduced it down to
a few lines of code, it might as well become a WPT.