Skip to content

Update QuotaExceededError expectations #53645

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Jul 28, 2025
Merged

Update QuotaExceededError expectations #53645

merged 7 commits into from
Jul 28, 2025

Conversation

@domenic
Copy link
Member

@domenic domenic commented Jul 8, 2025

@domenic domenic requested a review from a team as a code owner July 8, 2025 04:11
@wpt-pr-bot wpt-pr-bot requested review from titzer, twiss and wolenetz July 8, 2025 04:12
@domenic domenic mentioned this pull request Jul 8, 2025
Merged
15 tasks
This was referenced Jul 8, 2025
Merged
Merged
@domenic domenic force-pushed the quotaexceedederror-upgrade branch from aa7246b to b50f688 Compare July 8, 2025 04:36
@domenic domenic mentioned this pull request Jul 8, 2025
Merged
2 tasks
annevk
annevk requested changes Jul 16, 2025
View reviewed changes
Copy link
Member

@annevk annevk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A lot of these things appear like regressions to me. If we don't throw for the method involved the test ends up passing.

Can we instead extend assert_throws_dom and promise_rejects_dom to account for more complex exceptions?

@domenic
Copy link
Member Author

domenic commented Jul 17, 2025

Thanks for the push, I introduced new assert_throws_quotaexceedederror and promise_rejects_quotaexceedederror. I think that's necessary instead of reusing the _dom versions for (a) clarity; (b) to let us test the requested and quota properties.

annevk
annevk approved these changes Jul 17, 2025
View reviewed changes
Copy link
Member

@annevk annevk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. And let's copy @jgraham in case he's interested in reviewing the testharness.js changes.

foolip
foolip approved these changes Jul 18, 2025
View reviewed changes
@domenic @foolip
Apply suggestions from code review
05ac97c 
Co-authored-by: Philip Jägenstedt <[email protected]>
twiss
twiss approved these changes Jul 21, 2025
View reviewed changes
Copy link
Member

@twiss twiss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for the WebCrypto part

@domenic domenic merged commit 1d2c5fb into master Jul 28, 2025
38 of 44 checks passed
@domenic domenic deleted the quotaexceedederror-upgrade branch July 28, 2025 07:02
aarongable pushed a commit to chromium/chromium that referenced this pull request Aug 5, 2025
QuotaExceededError: Restore legacy exception code 22 to match spec
96ceb06 
Reverts just the code value change from crrev.com/c/6516473
Matches resolution in whatwg/webidl#1465
Tests updated in web-platform-tests/wpt#53645

Bug: 406162261
Fixed: 434432288
Change-Id: I2fe06c29c1773fdbec5765a18d5c59a0aa2235f8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6814000
Commit-Queue: Daniel Cheng <[email protected]>
Reviewed-by: Daniel Cheng <[email protected]>
Auto-Submit: Mike Wasserman <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1496718}
aarongable pushed a commit to chromium/chromium that referenced this pull request Aug 6, 2025
[M140] QuotaExceededError: Restore legacy exception code 22 to match …
32aa945 
…spec

Original change's description:
> QuotaExceededError: Restore legacy exception code 22 to match spec
> 
> Reverts just the code value change from crrev.com/c/6516473
> Matches resolution in whatwg/webidl#1465
> Tests updated in web-platform-tests/wpt#53645
> 
> Bug: 406162261
> Fixed: 434432288
> Change-Id: I2fe06c29c1773fdbec5765a18d5c59a0aa2235f8
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6814000
> Commit-Queue: Daniel Cheng <[email protected]>
> Reviewed-by: Daniel Cheng <[email protected]>
> Auto-Submit: Mike Wasserman <[email protected]>
> Cr-Commit-Position: refs/heads/main@{#1496718}

Bug: 436562744,406162261,434432288
Change-Id: I2fe06c29c1773fdbec5765a18d5c59a0aa2235f8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6818806
Commit-Queue: Rubber Stamper <[email protected]>
Bot-Commit: Rubber Stamper <[email protected]>
Auto-Submit: Chrome Cherry Picker <chrome-cherry-picker@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/7339@{#22}
Cr-Branched-From: 27be8b7-refs/heads/main@{#1496484}
@Ms2ger Ms2ger mentioned this pull request Aug 11, 2025
Closed
foolip pushed a commit that referenced this pull request Aug 13, 2025
@domenic @foolip
Update QuotaExceededError expectations (#53645)
19457a3 
See whatwg/webidl#1465.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@foolip foolip foolip approved these changes

@twiss twiss twiss approved these changes

@annevk annevk annevk approved these changes

@joeyparrish joeyparrish joeyparrish approved these changes

@ayuishii ayuishii Awaiting requested review from ayuishii

@beverloo beverloo Awaiting requested review from beverloo

@jakearchibald jakearchibald Awaiting requested review from jakearchibald

@jdm jdm Awaiting requested review from jdm

@jgraham jgraham Awaiting requested review from jgraham

@jrummell-chromium jrummell-chromium Awaiting requested review from jrummell-chromium

@mkruisselbrink mkruisselbrink Awaiting requested review from mkruisselbrink

@mnot mnot Awaiting requested review from mnot

@Ms2ger Ms2ger Awaiting requested review from Ms2ger

@siusin siusin Awaiting requested review from siusin

@titzer titzer Awaiting requested review from titzer

@wolenetz wolenetz Awaiting requested review from wolenetz

@youennf youennf Awaiting requested review from youennf

@yuki3 yuki3 Awaiting requested review from yuki3

@yutakahirano yutakahirano Awaiting requested review from yutakahirano

Assignees

@twiss twiss

Labels

ai background-fetch encrypted-media fetch fs infra media-source storage testharness.js wasm WebCryptoAPI webidl webstorage wg-cg_wicg wg-media wg-s_htmlwg wg-webcrypto

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@domenic @foolip @twiss @annevk @joeyparrish @wpt-pr-bot