Skip to content

Navigation API: navigation.back() inside of onnavigate should reject #56854

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
theIDinside wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Navigation API: navigation.back() inside of onnavigate should reject #56854

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 20 additions & 0 deletions ...gation-api/navigate-event/navigate-history-traversal-during-onnavigate-should-reject.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,20 @@
<!doctype html>
<script src="/resources/testharness.js"></script>
<script src="/resources/testharnessreport.js"></script>
<script src=/resources/testdriver.js></script>
<script src=/resources/testdriver-vendor.js></script>
<script>
promise_test(async t => {
let w = window.open("/common/blank.html");
await new Promise(resolve => w.onload = resolve);

await test_driver.bless("navigate", async function() {
w.navigation.navigate(new URL("resources/navigate-during-onnavigate-should-reject-helper.html", location.href).href);
Copy link
Member

@zcorpan zcorpan Dec 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can use a relative URL

Suggested change
w.navigation.navigate(new URL("resources/navigate-during-onnavigate-should-reject-helper.html", location.href).href);
w.navigation.navigate("resources/navigate-during-onnavigate-should-reject-helper.html");

});

await new Promise(resolve => onmessage = resolve);
w.postMessage("start", "*");
await new Promise(resolve => onmessage = resolve);
w.close();
}, "Test that await navigation.back().finished during onnavigate should reject");
</script>
Copy link
Member

@zcorpan zcorpan Dec 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LF at EOF please

23 changes: 23 additions & 0 deletions navigation-api/navigate-event/resources/navigate-during-onnavigate-should-reject-helper.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,23 @@
<!doctype html>
<head>
<script>
onload = () => {
opener.postMessage("load", "*");
};

onmessage = () => {
runTest();
}

async function runTest() {
await navigation.navigate("#1").finished;
navigation.onnavigate = async () => {
await navigation.back().finished.catch(() => {
opener.postMessage("done", "*");
})
}

history.back();
}
</script>
</head>