[ES6 modules] Update module linking procedures to follow latest spec updates#6194
Merged
chromium-wpt-export-bot merged 1 commit intomasterfrom Jun 12, 2017
Conversation
wpt-pr-bot
approved these changes
Jun 9, 2017
Collaborator
wpt-pr-bot
left a comment
wpt-pr-bot
left a comment
There was a problem hiding this comment.
Already reviewed downstream.
Firefox (nightly)Testing web-platform-tests at revision 8596b61 All results1 test ran/html/semantics/scripting-1/the-script-element/module/specifier-error.html
|
Sauce (safari)Testing web-platform-tests at revision 8596b61 All results1 test ran/html/semantics/scripting-1/the-script-element/module/specifier-error.html
|
Chrome (unstable)Testing web-platform-tests at revision 8596b61 All results1 test ran/html/semantics/scripting-1/the-script-element/module/specifier-error.html
|
Sauce (MicrosoftEdge)Testing web-platform-tests at revision 8596b61 All results1 test ran/html/semantics/scripting-1/the-script-element/module/specifier-error.html
|
…updates This CL updates Blink's impl of #internal-module-script-graph-fetching-procedure and #fetch-the-descendants-of-and-instantiate-a-module-script to match recent spec change: whatwg/html#2595 . Tests: external/wpt/html/semantics/scripting-1/the-script-element/module/specifier-error.html Bug: 727299, 594639 Change-Id: I022b3b380b408a6d5c75a59d161aea4fe2868f48 Reviewed-on: https://chromium-review.googlesource.com/528724 Commit-Queue: Kouhei Ueno <kouhei@chromium.org> Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#478219} WPT-Export-Revision: a1fd48a745a56045e25c3365a69f3fce0358074f
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-I022b3b380b408a6d5c75a59d161aea4fe2868f48
branch
from
74b2b18 to
77065b4
Compare
chromium-wpt-export-bot
deleted the
chromium-export-cl-I022b3b380b408a6d5c75a59d161aea4fe2868f48
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[ES6 modules] Update module linking procedures to follow latest spec updates
This CL updates Blink's impl of #internal-module-script-graph-fetching-procedure
and #fetch-the-descendants-of-and-instantiate-a-module-script to match
recent spec change: whatwg/html#2595 .
Tests: external/wpt/html/semantics/scripting-1/the-script-element/module/specifier-error.html
Bug: 727299, 594639
Change-Id: I022b3b380b408a6d5c75a59d161aea4fe2868f48
Reviewed-on: https://chromium-review.googlesource.com/528724
Commit-Queue: Kouhei Ueno kouhei@chromium.org
Reviewed-by: Kinuko Yasuda kinuko@chromium.org
Cr-Commit-Position: refs/heads/master@{#478219}
WPT-Export-Revision: a1fd48a745a56045e25c3365a69f3fce0358074f