Add more tests for FileReader.result. #7494
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Build BROKENStarted: 2017-09-26 20:43:16 Failing Jobs
View more information about this build on: |
In particular this adds tests to verify the value of the attribute during progress and loadstart events.
mkruisselbrink
force-pushed
the
filereader-tests
branch
from
4ba45d9 to
6625a32
Compare
Sorry about the delay, yes this is still valid. These are tests for the spec changes in w3c/FileAPI#118 |
| reader[method](blob); | ||
| assert_equals(reader.result, null, 'result is null after first read call'); | ||
| await eventWatcher.wait_for(event); | ||
| assert_equals(reader.result, null, 'result is null during event'); |
There was a problem hiding this comment.
Nice... and all browsers have converged on including the microtask execution within the event dispatch.
marcoscaceres
pushed a commit
that referenced
this pull request
Jul 23, 2019
In particular this adds tests to verify the value of the attribute during progress and loadstart events.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In particular this adds tests to verify the value of the attribute
during progress and loadstart events.
I think this matches what the spec currently says, but there are some open questions in w3c/FileAPI#79 about what the spec should actually say, so we should probably not merge this until we figure out what the desired behavior actually is.