[TASK] Streamline Localization handling #464
Conversation
The issue on TYPO3 13 having the button label writing outside the borders made a refactoring and regeneration of the localization.ts necessary. The labels were rewritten as CDATA to allow line breaks, getting rid of the too long labels. Together with TYPO3 Core standardized TSconfig for localizations the overridden JavaScript is more lightweight and doesn't need the AjaxRoute anymore. Therefore the AjaxRoutes.php and AjaxController.php are removed. In addition to Core functionality, the DeepL allow translateion now can be enabled/disabled by the following setting in Page TSConfig: ``` # Enabled (Default) mod.web_layout.localization.enableDeeplTranslate = 1 # Disabled mod.web_layout.localization.enableDeeplTranslate = 0 ``` This could be overridden in User TSconfig, too: ``` # Enabled (Default) page.mod.web_layout.localization.enableDeeplTranslate = 1 # Disabled page.mod.web_layout.localization.enableDeeplTranslate = 0 ```
calien666
force-pushed
the
bugfix/ts-button-text
branch
from
849fae5 to
4923ee5
Compare
The TCEmainHook.php was intentionally added allowing the override of the cmdMap array inside the DataHandler. As this was in older versions bad practice and the DataHandler hardening in v13 enforced `deepltranslate-core` introducing an own translation command as best practice, the hook allowing `localization` inside the cmdMap array is superfluous.
sbuerk
force-pushed
the
bugfix/ts-button-text
branch
from
4923ee5 to
cfdffc0
Compare
Hardblock 🛑 -2Points1. localization modal / text running out of field The "fixing" for the "label" is not "needed" in that way. That was already fixed, but limited to Here the "custom" class in the JS modal needs to be kept, and the CSS loading limit changed from
2. change of behaviour (only v13 in current patch state Due to the refactoring the "error/hint" when API key has not been configured are no longer shown in the selection and the deepltranslate items "disabled" (not selectable). That means, that with missing API key the options are "simply" not available, no notice for that. Do we really want this ? (Technically it's good to remove that). 3. removed configuration lookup code / dropped ajax route and controller I love that removal in general, even more as this removes sequentially retriggered ajax calls. However, only v13 JavaScript has been recompiled leaving the v12 JavaScript still trying to call that ajax endpoint removed with this pull request. That means, we need to adjust the TYPO3 v12 JavaScript in the same way. 4. PageTS options This is nice, but that is really a SummaryThere are quite some things we need to address and change, and I'd suppose to split it into dedicated parts. Must have is not breaking v12 support. |
No description provided.