Update to Vue 3 #1388
Merged
Update to Vue 3 #1388
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Preview this PR: https://custom-elements-everywhere.com/preview/preview/preview/1388/ |
AndrewJakubowicz
approved these changes
Feb 10, 2022
libraries/vue/package.json
Outdated
| @@ -14,11 +14,11 @@ | |||
| "karma-firefox-launcher": "2.1.2", | |||
| "karma-sourcemap-loader": "0.3.8", | |||
| "karma-webpack": "5.0.0", | |||
| "vue-template-compiler": "2.6.14", | |||
| "@vue/compiler-sfc": "^3.1.0", | |||
There was a problem hiding this comment.
Nit: Is this dependency required?
Ref: https://www.npmjs.com/package/@vue/compiler-sfc#:~:text=vue/compiler%2Dsfc%20deep%20import
| app.mount(scratch); | ||
| let wc = scratch.querySelector("#wc"); | ||
| await nextTick(); | ||
| await nextTick(); |
There was a problem hiding this comment.
Nit: Need tick twice?
There was a problem hiding this comment.
Yep, needed. Will leave a comment.
libraries/vue/src/advanced-tests.js
Outdated
| const app = createApp(ComponentWithDeclarativeEvent) | ||
| app.config.compilerOptions.isCustomElement = isCustomElement; | ||
| app.mount(scratch); | ||
| let wc = scratch.querySelector("#wc"); |
There was a problem hiding this comment.
Nits that don't need action. Prefer const to let here and on handled.
| "webpack": "5.65.0" | ||
| }, | ||
| "dependencies": { | ||
| "@webcomponents/webcomponentsjs": "2.6.0", | ||
| "vue": "2.6.14" | ||
| "vue": "^3.1.0" |
There was a problem hiding this comment.
Nit: Bump minor version to 3.2.30
There was a problem hiding this comment.
the '^' operator takes care of that, and the package-lock.json actually specifies the version that we test with
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.