-
-
Notifications
You must be signed in to change notification settings - Fork 253
test: standardize #214
Conversation
Codecov Report
@@ Coverage Diff @@
## master #214 +/- ##
==========================================
- Coverage 100% 97.14% -2.86%
==========================================
Files 2 2
Lines 35 35
Branches 16 16
==========================================
- Hits 35 34 -1
- Misses 0 1 +1
Continue to review full report at Codecov.
|
|
Just so I'm clear, this is essentially the P.O.C for the test initialization in defaults yet? |
|
More of a MVP, I'm working on the initial PR to defaults (with initial docs and better explanation), but this still could be improved in a lot of ways. I really just extracted the minimal stuff for now to not over engineer it and gather opinions about the approach and details, since it becomes fairly annoying to follow my reasoning otherwise :). A few more hours please so I can finish the defaults PR and rationale about the why/how/needs triage stuff |
32fd459 to
e27a945
Compare
e27a945 to
c72c277
Compare
c72c277 to
5b2e890
Compare
|
@evilebottnawi - Ship it when you are good with it. |
alexander-akait
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@d3viant0ne seems all good 👍
Notable ChangesIssues