Skip to content
This repository was archived by the owner on Mar 17, 2021. It is now read-only.

Conversation

@michael-ciniawsky
Copy link
Member

@michael-ciniawsky michael-ciniawsky commented Oct 3, 2017

Notable Changes

  • Refactor and standardizes tests

Issues

  • None

@codecov
Copy link

codecov bot commented Oct 3, 2017

Codecov Report

Merging #214 into master will decrease coverage by 2.85%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #214      +/-   ##
==========================================
- Coverage     100%   97.14%   -2.86%     
==========================================
  Files           2        2              
  Lines          35       35              
  Branches       16       16              
==========================================
- Hits           35       34       -1     
- Misses          0        1       +1
Impacted Files Coverage Δ
src/index.js 96.87% <0%> (-3.13%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f321874...5b2e890. Read the comment docs.

@michael-ciniawsky michael-ciniawsky requested a review from a team October 3, 2017 23:17
@joshwiens
Copy link
Member

Just so I'm clear, this is essentially the P.O.C for the test initialization in defaults yet?

@michael-ciniawsky
Copy link
Member Author

michael-ciniawsky commented Oct 4, 2017

More of a MVP, I'm working on the initial PR to defaults (with initial docs and better explanation), but this still could be improved in a lot of ways. I really just extracted the minimal stuff for now to not over engineer it and gather opinions about the approach and details, since it becomes fairly annoying to follow my reasoning otherwise :). A few more hours please so I can finish the defaults PR and rationale about the why/how/needs triage stuff

@michael-ciniawsky michael-ciniawsky force-pushed the test branch 2 times, most recently from 32fd459 to e27a945 Compare October 5, 2017 04:10
@michael-ciniawsky michael-ciniawsky changed the title [WIP] test: init test: init Nov 20, 2017
@michael-ciniawsky michael-ciniawsky changed the title test: init test: standardize Nov 20, 2017
@joshwiens
Copy link
Member

@evilebottnawi - Ship it when you are good with it.

Copy link
Member

@alexander-akait alexander-akait left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@d3viant0ne seems all good 👍

@michael-ciniawsky michael-ciniawsky removed this from the 1.1.6 milestone Jan 9, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants