Skip to content

Travis execution inline with webpack/webpack #69

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
3 tasks done
joshwiens opened this issue Jul 23, 2016 · 3 comments
Closed
3 tasks done

Travis execution inline with webpack/webpack #69

joshwiens opened this issue Jul 23, 2016 · 3 comments

Comments

@joshwiens
Copy link
Member

joshwiens commented Jul 23, 2016

Bring html-loaders travis execution inline with webpack core

  • Add linting
  • Add coverage generation / reporting via codecov.io
  • Status badges in readme ( Readme template coming from @michael-ciniawsky )
@joshwiens
Copy link
Member Author

@hemanth - https://codecov.io/gh/webpack/html-loader requires write access to enable initially.

@hemanth
Copy link
Contributor

hemanth commented Jul 24, 2016

@d3viant0ne I have the write access.

Good going!

@joshwiens
Copy link
Member Author

@hemanth - The build was broken in #master as of yesterday when I first forked. 4 failing tests but there was no travis feedback on PRs so evidently it went undetected.

Much like the linting fixes, I was going to fix the tests in the PR that updates the Travis execution #74 so we can get proper validation in pull requests going forward.

Just to be very clear, every PR open right now has 4 failing tests, as does the master branch as of yesterday when I first looked. There is no travis feedback in the PRs, which is why they are green.

#66 for instance ..
screen shot 2016-07-24 at 11 43 59 am

Though if you go look at the builds for master in Travis ..

screen shot 2016-07-24 at 11 45 56 am

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants