-
-
Notifications
You must be signed in to change notification settings - Fork 205
Add support for srcset #55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Good idea, but I think this could be solved in a more elegant way. Try to leave all existing code as it was before and only modify the This way we don't need to touch the additional stuff after the url. And please add some tests. |
Added support for img:secset and other comma serperated lists; img:srcset is handeled by default
# Conflicts: # README.md
As you suggested I implemented the srcset support by only modifying the links array. And I added some tests. |
Any news on merging? Just googled this issue. Srcset is very useful attribute, and we really can use it according to caniuse. Most of default retina-devices browsers support it. |
Any idea on when this pull request will be merged? |
You know - what would be even more awesome is if the loader could automatically generate a |
@iljadaderko - Shortly @hemanth - LGTM though a second set of eyes would be helpful. |
@akesser - Please pull in the latest changes from master to enable all the Travis validations prior to merge. |
@d3viant0ne #66 needs a rebase. |
#66 can be closed. Travis updates in master accomplished the same thing |
Done. @d3viant0ne COVERALLS setup is not up yet. |
@akesser |
I updated my index.js file to pass the nom test |
I added support for comma separated lists in attributes to be able to handle
srcset
For example
is converted to
Gruß
-akesser-