Update html-minifier #20
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks
You propably want to add a testcase for svg handling to the html-loader, so we don't break in anytime soon... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
html-minifier has undergone a number of enhancements since 0.5. This PR simply updates the version to ^0.7.2 and fixes a test that failed with the new version. I've tested this patched version of html-loader with a large webpack project and things are good.
My main motivation for submitting this PR is one of the enhancements in the later versions of the module. html-minifier now supports properly handling
<svg>elements and knows not to remove trailing slashes from singleton elements within SVGs. SVGs included via html-loader are a big part of my team's webpack project and were showing some major issues when minification was turned on.Thanks!