Skip to content

Revert "Add support for srcset" #79

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 25, 2016
Merged

Revert "Add support for srcset" #79

merged 1 commit into from
Jul 25, 2016

Conversation

hemanth
Copy link
Contributor

@hemanth hemanth commented Jul 25, 2016

@akesser reverting this, let us take this as a new feature altogether.

As @d3viant0ne pointed out, there are lot of edge cases for this to handle.

@codecov-io
Copy link

codecov-io commented Jul 25, 2016

Current coverage is 95.77% (diff: 100%)

No coverage report found for master at e67d13c.

Powered by Codecov. Last update e67d13c...f709bcd

@hemanth hemanth merged commit 1908e96 into master Jul 25, 2016
@geoffreydhuyvetters
Copy link

what's the plan on this one? would be a nice addition

@maryo
Copy link

maryo commented Feb 7, 2017

@hemanth @d3viant0ne Which edge cases? Is it listed somewhere? I couldn't find it :-/. This feature can be optional.

EDIT: I've created a temporary fork https://github.com/maryo/html-loader where I've added back the reverted functionality.

npm i github:maryo/html-loader --save-dev

@timofei-iatsenko
Copy link

Want to open this discussion again, it's quite nice feature feature, otherwise I have to copy-paste code like that

   <img
                 src="./assets/menu-screenshot.png"
                 srcset="./assets/menu-screenshot-2x.png 2x"
                 data-src="./assets/menu-screenshot-2x.png"
                 class="select-country-page__preview"/>

@joshwiens joshwiens deleted the revert-55-master branch June 5, 2017 09:48
@yawlhead91
Copy link

Any news with the srcset support

@alexander-akait
Copy link
Member

@bstaruk
Copy link

bstaruk commented Jul 28, 2018

I'm also interested in hearing about the edge cases mentioned in the original comment on this thread.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants